Skip to content

[Cloud Asset Inventory] Add required_vars #13714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

[Cloud Asset Inventory] Add required_vars #13714

merged 3 commits into from
Apr 30, 2025

Conversation

romulets
Copy link
Member

Proposed commit message

Add required_vars to Cloud Asset Inventory to complement elastic/kibana#219001

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@romulets romulets added the enhancement New feature or request label Apr 29, 2025
@romulets romulets self-assigned this Apr 29, 2025
@romulets romulets requested a review from a team as a code owner April 29, 2025 07:55
@romulets romulets force-pushed the asset-inventory-required-vars branch from 17a21b7 to 4a0da4c Compare April 29, 2025 07:56
@oren-zohar oren-zohar requested review from seanrathier and orouz April 29, 2025 11:41
@andrewkroh andrewkroh added Integration:cloud_asset_inventory Cloud Asset Discovery Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] labels Apr 29, 2025
seanrathier
seanrathier approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@seanrathier seanrathier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the lead. I noticed an issue in Azure for both Asset and CSPM. Were missing an input in the validation

https://github.com/elastic/integrations/pull/13714/files#diff-c6b59381e36100b7bcadab6edae6fb3400124a01ab91eba1634009ef720a66eaR186

@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @romulets

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Apr 29, 2025
@romulets romulets merged commit 8c2b194 into elastic:main Apr 30, 2025
6 of 7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package cloud_security_posture - 2.0.0-preview02 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/2.0.0-preview02/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanrathier seanrathier seanrathier approved these changes

@orouz orouz orouz approved these changes

Assignees

@romulets romulets

Labels
enhancement New feature or request Integration:cloud_asset_inventory Cloud Asset Discovery Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romulets @elasticmachine @seanrathier @orouz @andrewkroh