Skip to content

Use journald input by default when running system integration for SLES 15-SP6 #13759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 24, 2025
Merged

Use journald input by default when running system integration for SLES 15-SP6 #13759

merged 7 commits into from
Jun 24, 2025

Conversation

pierrehilbert
Copy link
Contributor

@pierrehilbert pierrehilbert commented May 2, 2025 •
edited
Loading

Proposed commit message

Use journald input by default when running system integration for SLES 15-SP6.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@pierrehilbert pierrehilbert added enhancement New feature or request Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels May 2, 2025
@pierrehilbert pierrehilbert requested review from a team as code owners May 2, 2025 07:02
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from rdner, cmacknz and faec May 2, 2025 07:03
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented May 2, 2025 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels May 2, 2025
@rdner
Copy link
Member

rdner commented May 6, 2025

@pierrehilbert there are not testing steps in the description.

Was it tested or you would like me to run the tests?

@pierrehilbert
Copy link
Contributor Author

@amolnater-qasource tested the fix by manually changing the configuration here: #13752 (comment)

But always great to have more folks confirming this is working the correct way.

shmsr
shmsr reviewed May 7, 2025
View reviewed changes
ishleenk17
ishleenk17 reviewed May 7, 2025
View reviewed changes
@ishleenk17
Copy link
Member

@pierrehilbert
Also, there might be more such platform/os_version combinations we might have missed/not known.
We always have the condition config option for the user to change that. So I don't think this should be a concern. WDYT ?
Current behaviour if in case these log inputs are used is that just they won't see any logs, is that right?

shmsr
shmsr reviewed May 7, 2025
View reviewed changes
@pierrehilbert pierrehilbert requested review from shmsr and ishleenk17 May 25, 2025 17:50
@pierrehilbert
Copy link
Contributor Author

@ishleenk17 / @shmsr Can I get another review here please?

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

@pierrehilbert pierrehilbert merged commit 1ddb119 into main Jun 24, 2025
7 checks passed
@pierrehilbert pierrehilbert deleted the system-journald-sles15 branch June 24, 2025 14:16
@elastic-vault-github-plugin-prod
Copy link

Package system - 2.3.1 containing this change is available at https://epr.elastic.co/package/system/2.3.1/

shmsr pushed a commit to shmsr/integrations that referenced this pull request Jun 30, 2025
@pierrehilbert @rdner @shmsr
Use journald input by default when running system integration for SLE…
1a01e10 
…S 15-SP6 (elastic#13759)

* Use journald input by default when running system integration for SLES15-SP6

* Update changelog.yml

---------

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner approved these changes

@nfritts nfritts nfritts approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz

@faec faec Awaiting requested review from faec

@shmsr shmsr Awaiting requested review from shmsr

Assignees
No one assigned
Labels
enhancement New feature or request Integration:system System Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLES 15]: No "system.auth" logs for system integration under Data Streams tab for SLES 15 linux agent.
8 participants
@pierrehilbert @elasticmachine @rdner @ishleenk17 @cmacknz @shmsr @nfritts @andrewkroh