Skip to content

[github] New Security Advisories data stream #13876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 70 commits into from
Jun 9, 2025
Merged

[github] New Security Advisories data stream #13876

merged 70 commits into from
Jun 9, 2025

Conversation

clement-fouque
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@clement-fouque
Initial commut
ce0be69
@clement-fouque
Set PR
2b8f377
@clement-fouque
feat(miniflux): add configuration files for Miniflux API integration …
0bed97d 
…and update manifest
@clement-fouque
Add pipeline and fields mapping
3aa52fe
@clement-fouque
Assign miniflux integration codeowner to security-service-integrations
1164a90
@clement-fouque
Change initial version
f14fddf
@clement-fouque
Change owner to security-integrations
38d798a
@clement-fouque
Change initial version to 0.1.0
9371755
@clement-fouque
Review documentation
6e25041
@clement-fouque
Remove empty line
3962078
@clement-fouque
Rebuild for CI
5520709
@clement-fouque
Remove experimental function that was inadvertly added
cccaaaa
@clement-fouque
Fix system test
57ea91a
@clement-fouque
Correct path
907d068
@clement-fouque
Rebuild doc
1a26a85
@clement-fouque
Add event to the doc
1afe16c
@clement-fouque
Add system tests
e2bc166
@clement-fouque
Removing query_params
7102811
@clement-fouque
Format files
3ea1e0b
@clement-fouque
Add feed entry split by regex functionnality
e89155c
@clement-fouque
Rebuild doc and sample events
125a97f
@clement-fouque
Remove sytem tests
2c28d20
@clement-fouque
Rebuild integration
086a4fb
@clement-fouque
Add system tests
3a1bd82
@clement-fouque
Add Miniflux logo
515246f
@clement-fouque
Implement review recommendations
26a4231
@clement-fouque
Add 9.X kibana condition
ba9d1b1
@clement-fouque
Initial commit
5953543
@clement-fouque
Merge branch 'main' into github_security_advisory
bb1b9b4
@clement-fouque
Update PR number
c50c206
@andrewkroh andrewkroh removed the New Integration Issue or pull request for creating a new integration package. label Jun 4, 2025
@clement-fouque
Copy link
Contributor Author

Thank you @kcreddy for your help today! I think I have a better understanding on how system tests works!

The PR is ready for review.

@clement-fouque clement-fouque requested review from kcreddy and efd6 June 4, 2025 21:57
efd6
efd6 reviewed Jun 4, 2025
View reviewed changes
@clement-fouque
Copy link
Contributor Author

I've implemented suggestions. It's ready for another review. Thanks.

@clement-fouque clement-fouque requested a review from efd6 June 5, 2025 15:58
efd6
efd6 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for @kcreddy

kcreddy
kcreddy reviewed Jun 6, 2025
View reviewed changes
@clement-fouque
Copy link
Contributor Author

I've implemented all suggestions. Can you please review and approve if ready? Thanks.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
94.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

@clement-fouque clement-fouque merged commit 0a051f9 into main Jun 9, 2025
7 checks passed
@clement-fouque clement-fouque deleted the github_security_advisory branch June 9, 2025 09:52
@elastic-vault-github-plugin-prod
Copy link

Package github - 2.8.0 containing this change is available at https://epr.elastic.co/package/github/2.8.0/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:github GitHub Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clement-fouque @elasticmachine @efd6 @kcreddy @andrewkroh