Skip to content

fix missing config in system core data stream #13883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025

Conversation

stefans-elastic
Copy link
Contributor

@stefans-elastic stefans-elastic commented May 12, 2025

Proposed commit message

Fix missing config in system core data stream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #9267

Screenshots

The config shows up in integrations config
Screenshot 2025-05-12 at 11 45 54 AM

Elastic Agent is healthy
Screenshot 2025-05-12 at 11 44 37 AM

Metrics show up in kibana
Screenshot 2025-05-12 at 11 44 19 AM

@stefans-elastic stefans-elastic self-assigned this May 12, 2025
@stefans-elastic stefans-elastic requested review from a team as code owners May 12, 2025 08:53
@stefans-elastic stefans-elastic added the bug Something isn't working, use only for issues label May 12, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@muthu-mps
Copy link
Contributor

@stefans-elastic - Have you observed the fetching interval change while upgrading the integration? As the 10s is applied now, what is the fetch period earlier?

stefans-elastic and others added 2 commits May 12, 2025 13:05
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @stefans-elastic

Copy link

@stefans-elastic
Copy link
Contributor Author

@stefans-elastic - Have you observed the fetching interval change while upgrading the integration? As the 10s is applied now, what is the fetch period earlier?

Judging from what is seen in metricbeat (system.yml, data.json) it was 10 secs.

@andrewkroh andrewkroh added Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels May 12, 2025
@muthu-mps muthu-mps merged commit 74d3822 into elastic:main May 15, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package system - 2.0.1 containing this change is available at https://epr.elastic.co/package/system/2.0.1/

@stefans-elastic stefans-elastic deleted the system-period branch May 15, 2025 09:37
anupratharamachandran pushed a commit to anupratharamachandran/integrations that referenced this pull request Jun 2, 2025
* Fix missing  config in system core data stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:system System Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System] The core metrics do not use the period variable
4 participants