Skip to content

opencanary: implement password redaction via gsub #14036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 29, 2025

Proposed commit message

opencanary: implement password redaction via gsub

The redact processor is not available for basic subscriptions, so
replace it with gsub to prevent CI failing when testing with that
subscription. This allows us to re-enable the testing of this
behaviour.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this May 29, 2025
@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:opencanary OpenCanary (Community supported) labels May 29, 2025
@efd6 efd6 force-pushed the 13551-opencanary branch from e63539e to b7a99a6 Compare May 29, 2025 02:38
The redact processor is not available for basic subscriptions, so
replace it with gsub to prevent CI failing when testing with that
subscription. This allows us to re-enable the testing of this
behaviour.
@efd6 efd6 force-pushed the 13551-opencanary branch from b7a99a6 to 416db5d Compare May 29, 2025 02:44
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review May 29, 2025 03:10
@efd6 efd6 requested a review from a team as a code owner May 29, 2025 03:10
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 merged commit eceb315 into elastic:main May 29, 2025
8 checks passed
@elastic-vault-github-plugin-prod

Package opencanary - 0.5.0 containing this change is available at https://epr.elastic.co/package/opencanary/0.5.0/

@navnit-elastic navnit-elastic mentioned this pull request Jun 2, 2025
26 tasks
anupratharamachandran pushed a commit to anupratharamachandran/integrations that referenced this pull request Jun 2, 2025
The redact processor is not available for basic subscriptions, so
replace it with gsub to prevent CI failing when testing with that
subscription. This allows us to re-enable the testing of this
behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:opencanary OpenCanary (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants