Skip to content

[entityanalytics_ad] Remove members from group information by default #14173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Jun 6, 2025

Proposed commit message

[entityanalytics_ad] Remove members from group information by default

The `entityanalytics_ad.groups.member` field can be very large if the
user is a member of a large group.

We want information about groups a user belongs, but we don't need a
list of every other member of the group, so this field is no longer
populated by default.

Alongside the existing advanced option to request specific group
attributes, there is a new advanced option (off by default) to preserve
the member list.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@chrisberkhout chrisberkhout self-assigned this Jun 6, 2025
@chrisberkhout chrisberkhout added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:entityanalytics_ad Active Directory Entity Analytics labels Jun 6, 2025
@chrisberkhout chrisberkhout force-pushed the entityanalytics_ad-remove-group-member-list branch from df8203c to 20d7b19 Compare June 6, 2025 13:07
@chrisberkhout chrisberkhout changed the title [entityanalytics_ad] Remove members from group information, by default [entityanalytics_ad] Remove members from group information by default Jun 6, 2025
@chrisberkhout chrisberkhout marked this pull request as ready for review June 6, 2025 13:09
@chrisberkhout chrisberkhout requested a review from a team as a code owner June 6, 2025 13:09
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@chrisberkhout chrisberkhout enabled auto-merge (squash) June 6, 2025 13:29
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@chrisberkhout chrisberkhout merged commit 655beda into elastic:main Jun 6, 2025
5 checks passed
@elasticmachine
Copy link

💚 Build Succeeded

cc @chrisberkhout

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elastic-vault-github-plugin-prod

Package entityanalytics_ad - 0.14.1 containing this change is available at https://epr.elastic.co/package/entityanalytics_ad/0.14.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:entityanalytics_ad Active Directory Entity Analytics Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[entityanalytics_ad]: Investigate efficient handling of group membership data
3 participants