-
Notifications
You must be signed in to change notification settings - Fork 474
Add VertexAI Auditlogs Dashboard #14184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
🚀 Benchmarks reportTo see the full report comment with |
packages/gcp_vertexai/kibana/dashboard/gcp_vertexai-d566516f-06fd-47e0-aba1-44148598c59a.json
Show resolved
Hide resolved
packages/gcp_vertexai/kibana/dashboard/gcp_vertexai-d566516f-06fd-47e0-aba1-44148598c59a.json
Show resolved
Hide resolved
packages/gcp_vertexai/kibana/dashboard/gcp_vertexai-d566516f-06fd-47e0-aba1-44148598c59a.json
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I like the map of locations. Some users might want to see a list of locations for reasons such as easier to copy-paste, easier to grasp when there is a large number of locations (enterprise customer). Could we also add a list of the same locations next to the map?
- The second pie widget has two email addresses (privacy issues). Could we scrub those (maybe replace them with fake ones or just blur them). Perhaps no need to re-generate the dashboard, just do it manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniela-elastic I have added the region names from which audit logs have been received. Does this look better ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, please address before merge
Yes, I'll be doing that once all the comments are addressed
Can you point me to which title case you are talking about ?
Pie chart gives an idea which email was used the most. Also, its inline with the GCP auditlogs.
Addressed |
Screenshot updated after addressing latest comments |
I am adding an example panel title from both the dashboards. This applies for all the panels in the dashboard.
|
Addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comment on tags, change looks good to me otherwise.
Please update the dashboard images after updating the links. The audit log dashboard also needs the current dashboard link to be included which doesn't exist now.
packages/gcp_vertexai/kibana/search/gcp_vertexai-201625b6-343e-43c7-ab67-e77d1f8ed790.json
Outdated
Show resolved
Hide resolved
|
💚 Build Succeeded
History
cc @ishleenk17 |
Package gcp_vertexai - 1.3.0 containing this change is available at https://epr.elastic.co/package/gcp_vertexai/1.3.0/ |
@ishleenk17 - Have the screenshots updated with dashboard links? They seem to be missing. |
https://github.com/elastic/integrations/pull/14184/files#diff-7887b792c58136f11ea0a7072d391460897a6a96b7b35ba12640f805b2ee6083, yes the link is there in auditlogs. Check this image. The older metrics overview dashboard will need update for the link. |
We might need to update both dashboards. The updated dashboard would display links to the previous dashboard as well as the currently selected one, with the link for the selected dashboard highlighted. ![]() |
In this PR we are doing the below:
Proposed commit message
See title
Checklist
changelog.yml
file.Related issues
Screenshots