Skip to content

Add VertexAI Auditlogs Dashboard #14184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 13, 2025

Conversation

ishleenk17
Copy link
Member

@ishleenk17 ishleenk17 commented Jun 9, 2025

In this PR we are doing the below:

  1. Create new dashboard for Auditlogs
  2. Link the metrics and logs dashboard to each other
  3. Add geo field support in the pipeline as we use that for the dashboard

Proposed commit message

See title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

Screenshots

Screenshot 2025-06-11 at 1 27 20 PM

@ishleenk17 ishleenk17 self-assigned this Jun 9, 2025
@ishleenk17 ishleenk17 marked this pull request as ready for review June 9, 2025 07:43
@ishleenk17 ishleenk17 requested a review from a team as a code owner June 9, 2025 07:43
@ishleenk17
Copy link
Member Author

/test

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 9, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:gcp_vertexai GCP Vertex AI Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jun 9, 2025
@muthu-mps
Copy link
Contributor

  • Dashboard linking requires updated image in the overview chart as well.
  • Title case is applied to Audit logs, whereas the existing overview dashboard uses a different formatting style. Can we align the formatting here to match the style used in the overview dashboard?
  • Do we need to show the Audit event email address in the visualization? My suggestion is include email in the table view is useful. WDYT?
  • We can think of removing Audit in the title name as well. e.x. [Logs GCP VertexAI] Event Action instead of Audit Event Action.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I like the map of locations. Some users might want to see a list of locations for reasons such as easier to copy-paste, easier to grasp when there is a large number of locations (enterprise customer). Could we also add a list of the same locations next to the map?
  2. The second pie widget has two email addresses (privacy issues). Could we scrub those (maybe replace them with fake ones or just blur them). Perhaps no need to re-generate the dashboard, just do it manually

Copy link
Member Author

@ishleenk17 ishleenk17 Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniela-elastic I have added the region names from which audit logs have been received. Does this look better ?
Screenshot 2025-06-11 at 1 28 44 AM

Copy link

@daniela-elastic daniela-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, please address before merge

@ishleenk17
Copy link
Member Author

ishleenk17 commented Jun 10, 2025

  • Dashboard linking requires updated image in the overview chart as well.

Yes, I'll be doing that once all the comments are addressed

  • Title case is applied to Audit logs, whereas the existing overview dashboard uses a different formatting style. Can we align the formatting here to match the style used in the overview dashboard?

Can you point me to which title case you are talking about ?

  • Do we need to show the Audit event email address in the visualization? My suggestion is include email in the table view is useful. WDYT?

Pie chart gives an idea which email was used the most. Also, its inline with the GCP auditlogs.

  • We can think of removing Audit in the title name as well. e.x. [Logs GCP VertexAI] Event Action instead of Audit Event Action.

Addressed

@ishleenk17
Copy link
Member Author

Screenshot updated after addressing latest comments

@muthu-mps
Copy link
Contributor

  • Title case is applied to Audit logs, whereas the existing overview dashboard uses a different formatting style. Can we align the formatting here to match the style used in the overview dashboard?

Can you point me to which title case you are talking about ?

I am adding an example panel title from both the dashboards. This applies for all the panels in the dashboard.

Overview dashboard Audit logs dashboard
Token usage - by model deployment Audit Event Email

@ishleenk17
Copy link
Member Author

  • Title case is applied to Audit logs, whereas the existing overview dashboard uses a different formatting style. Can we align the formatting here to match the style used in the overview dashboard?

Can you point me to which title case you are talking about ?

I am adding an example panel title from both the dashboards. This applies for all the panels in the dashboard.

Overview dashboard Audit logs dashboard
Token usage - by model deployment Audit Event Email

Addressed

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comment on tags, change looks good to me otherwise.
Please update the dashboard images after updating the links. The audit log dashboard also needs the current dashboard link to be included which doesn't exist now.

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @ishleenk17

@ishleenk17 ishleenk17 merged commit e732336 into elastic:main Jun 13, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package gcp_vertexai - 1.3.0 containing this change is available at https://epr.elastic.co/package/gcp_vertexai/1.3.0/

@muthu-mps
Copy link
Contributor

Screenshot updated after addressing latest comments

@ishleenk17 - Have the screenshots updated with dashboard links? They seem to be missing.

@ishleenk17
Copy link
Member Author

Screenshot updated after addressing latest comments

@ishleenk17 - Have the screenshots updated with dashboard links? They seem to be missing.

https://github.com/elastic/integrations/pull/14184/files#diff-7887b792c58136f11ea0a7072d391460897a6a96b7b35ba12640f805b2ee6083, yes the link is there in auditlogs. Check this image.

The older metrics overview dashboard will need update for the link.

@muthu-mps
Copy link
Contributor

Screenshot updated after addressing latest comments

@ishleenk17 - Have the screenshots updated with dashboard links? They seem to be missing.

https://github.com/elastic/integrations/pull/14184/files#diff-7887b792c58136f11ea0a7072d391460897a6a96b7b35ba12640f805b2ee6083, yes the link is there in auditlogs. Check this image.

The older metrics overview dashboard will need update for the link.

We might need to update both dashboards. The updated dashboard would display links to the previous dashboard as well as the currently selected one, with the link for the selected dashboard highlighted.

Screenshot 2025-06-13 at 3 03 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:gcp_vertexai GCP Vertex AI Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants