Skip to content

Fix minor spelling mistakes #14190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix minor spelling mistakes #14190

merged 1 commit into from
Jun 27, 2025

Conversation

max-chaban
Copy link
Contributor

@max-chaban max-chaban commented Jun 10, 2025 •
edited
Loading

Proposed commit message

Fixed minor spelling mistakes

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@max-chaban max-chaban self-assigned this Jun 10, 2025
@max-chaban max-chaban requested a review from a team as a code owner June 10, 2025 08:09
@max-chaban max-chaban added the bug Something isn't working, use only for issues label Jun 10, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 10, 2025 •
edited
Loading

🚀 Benchmarks report

Package github 👍(4) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
issues 4201.68 3448.28 -753.4 (-17.93%) 💔

To see the full report comment with /test benchmark fullreport

@max-chaban max-chaban force-pushed the fix/spelling-in-github-security-advisories branch from 64a12fa to 3c9230f Compare June 10, 2025 08:40
@max-chaban max-chaban changed the title Fix minor spelling mistake in GitHub Security Advisories Fix minor spelling mistakes Jun 10, 2025
@andrewkroh andrewkroh added Integration:miniflux Miniflux RSS reader Integration:github GitHub Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 10, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh
Copy link
Member

The two changed packages need a changelog entry and patch version bump. You can use elastic-package changelog add to accomplish this. For example

elastic-package -C packages/github changelog add --next patch --type bugfix --link "https://github.com/elastic/integrations/pull/14190" --description '<changelog text here>'

elastic-package -C packages/miniflux changelog add --next patch --type bugfix --link "https://github.com/elastic/integrations/pull/14190" --description '<changelog text here>'

@max-chaban
Copy link
Contributor Author

The two changed packages need a changelog entry and patch version bump. You can use elastic-package changelog add to accomplish this. For example

elastic-package -C packages/github changelog add --next patch --type bugfix --link "https://github.com/elastic/integrations/pull/14190" --description '<changelog text here>'

elastic-package -C packages/miniflux changelog add --next patch --type bugfix --link "https://github.com/elastic/integrations/pull/14190" --description '<changelog text here>'

Ok, thank you, I will add changes today

@max-chaban max-chaban force-pushed the fix/spelling-in-github-security-advisories branch 2 times, most recently from a3ceed2 to 9a7513e Compare June 11, 2025 08:20
kcreddy
kcreddy reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits. LGTM otherwise

@max-chaban max-chaban force-pushed the fix/spelling-in-github-security-advisories branch from 5fd84e4 to 840ae38 Compare June 11, 2025 11:03
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue and removed bug Something isn't working, use only for issues labels Jun 11, 2025
@max-chaban max-chaban force-pushed the fix/spelling-in-github-security-advisories branch from 840ae38 to edbe3d3 Compare June 27, 2025 09:51
@max-chaban
Copy link
Contributor Author

Bumped packages/github to be on top of new change from main (to 2.8.2)

@kuisathaverat
Copy link
Contributor

@andrewkroh as Max cannot merge it, if there are no objections, I will merge this PR

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @max-chaban

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@andrewkroh andrewkroh merged commit 21ae013 into main Jun 27, 2025
8 checks passed
@andrewkroh andrewkroh deleted the fix/spelling-in-github-security-advisories branch June 27, 2025 18:38
@elastic-vault-github-plugin-prod
Copy link

Package github - 2.8.2 containing this change is available at https://epr.elastic.co/package/github/2.8.2/

@elastic-vault-github-plugin-prod
Copy link

Package miniflux - 0.2.1 containing this change is available at https://epr.elastic.co/package/miniflux/0.2.1/

shmsr pushed a commit to shmsr/integrations that referenced this pull request Jun 30, 2025
@max-chaban @shmsr
fix(miniflux,github): minor spelling mistakes (elastic#14190)
eec5e6f 
Fix typos in some data streams manifests for the github
and miniflux integrations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy left review comments

@andrewkroh andrewkroh andrewkroh approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@max-chaban max-chaban

Labels
bugfix Pull request that fixes a bug issue Integration:github GitHub Integration:miniflux Miniflux RSS reader Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@max-chaban @elasticmachine @andrewkroh @kuisathaverat @kcreddy