-
Notifications
You must be signed in to change notification settings - Fork 474
[nozomi_networks] Initial release of the Nozomi Networks #14192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportTo see the full report comment with |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only checked alert
and asset
datastreams.
packages/nozomi_networks/data_stream/alert/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/alert/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/alert/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/asset/_dev/test/pipeline/test-asset.log-expected.json
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/asset/_dev/test/pipeline/test-asset.log-expected.json
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/asset/_dev/test/pipeline/test-asset.log-expected.json
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/asset/_dev/test/pipeline/test-asset.log-expected.json
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/alert/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/asset/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/audit/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/node/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/node_cve/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/session/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/variable/agent/stream/cel.yml.hbs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please wait for @kcreddy
- set: | ||
field: event.severity | ||
tag: set_event_severity_from_alert_severity | ||
copy_from: nozomi_networks.alert.severity | ||
ignore_empty_value: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we don’t have any official documentation to show the severity levels for this range.
If no docs, I suggest please reach out to Nozomi if you are in contact already to understand how we can correspond their 0-10
range into Elastic range.
Or document it as a known limitation (inside README) that event.severity
isn't normalised as per Elastic Security Solution. This should be eventually fixed before making integration GA.
packages/nozomi_networks/data_stream/asset/_dev/test/pipeline/test-asset.log-expected.json
Outdated
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/asset/_dev/test/pipeline/test-asset.log-expected.json
Show resolved
Hide resolved
packages/nozomi_networks/data_stream/node_cve/sample_event.json
Outdated
Show resolved
Hide resolved
...ages/nozomi_networks/data_stream/node_cve/_dev/test/pipeline/test-node-cve.log-expected.json
Outdated
Show resolved
Hide resolved
...ages/nozomi_networks/data_stream/node_cve/_dev/test/pipeline/test-node-cve.log-expected.json
Outdated
Show resolved
Hide resolved
...ages/nozomi_networks/data_stream/node_cve/_dev/test/pipeline/test-node-cve.log-expected.json
Outdated
Show resolved
Hide resolved
...ages/nozomi_networks/data_stream/node_cve/_dev/test/pipeline/test-node-cve.log-expected.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mostly. Pending:
- Recent doc updates: #14192 (comment)
event.severity
normalisation: #14192 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please check #14014 and conform the README to this latest standard as suggested by our docs team?
Take a look at proofpoint_itm
or qualys_vmdr
for example from the PR. They have similar README (agentless related) to this one.
Can you please update your README template too? cc: @piyush-elastic
…README documentation
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Package nozomi_networks - 0.1.0 containing this change is available at https://epr.elastic.co/package/nozomi_networks/0.1.0/ |
The initial release includes an alert, asset, audit, health, node, node cve, session and variable data stream and associated dashboards and visualizations. Nozomi Networks fields are mapped to their corresponding ECS fields where possible. Test samples were derived from documentation.
Proposed commit message
The initial release includes an alert, asset, audit, health, node, node cve, session and variable data stream and associated dashboards and visualizations.
Nozomi Networks fields are mapped to their corresponding ECS fields where possible.
Test samples were derived from documentation.
Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshot