Skip to content

[GitHub][Security Advisories] Fix - include advisory_type in state for next interval #14273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2025

Conversation

clement-fouque
Copy link
Contributor

@clement-fouque clement-fouque commented Jun 19, 2025

I had the following error.
image

I realised that after the first interval, the second interval call is missing the advisory_type. By adding it to the state, it should fix the issue.

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@clement-fouque clement-fouque changed the title fix(github/security_advisories): include advisory_type in state for next interval [GitHub][Security Advisories] Fix - include advisory_type in state for next interval Jun 19, 2025
@clement-fouque clement-fouque added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jun 19, 2025
@clement-fouque
Copy link
Contributor Author

I've confirmed on my local instance that the second interval (10m) is working as expected.
image

@clement-fouque clement-fouque marked this pull request as ready for review June 19, 2025 21:52
@clement-fouque clement-fouque requested a review from a team as a code owner June 19, 2025 21:52
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix LGTM, but there are unrelated or unnecessary changes that I think should be reverted. If these are require for other changes, they should be in a separate PR.

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

@clement-fouque clement-fouque merged commit f3faacf into main Jun 20, 2025
7 checks passed
@clement-fouque clement-fouque deleted the github_security_advisories branch June 20, 2025 09:16
@elastic-vault-github-plugin-prod

Package github - 2.8.1 containing this change is available at https://epr.elastic.co/package/github/2.8.1/

shmsr pushed a commit to shmsr/integrations that referenced this pull request Jun 30, 2025
@clement-fouque clement-fouque restored the github_security_advisories branch July 2, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:github GitHub Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants