Skip to content

gitlab: fix field type and value for event.duration #14299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 23, 2025

Proposed commit message

gitlab: fix field type and value for event.duration

The value of the field returned by the gitlab API is a floating point
number that appears to be seconds based on the example document here[1].
So divide by nanos and convert it to a long.

[1]https://docs.gitlab.com/administration/logs/#sidekiq-logs

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 23, 2025
@efd6 efd6 added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:gitlab GitLab labels Jun 23, 2025
The value of the field returned by the gitlab API is a floating point
number that appears to be seconds based on the example document here[1].
So divide by nanos and convert it to a long.

[1]https://docs.gitlab.com/administration/logs/#sidekiq-logs
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package gitlab 👍(1) 💚(4) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
auth 6172.84 4524.89 -1647.95 (-26.7%) 💔
sidekiq 10526.32 6578.95 -3947.37 (-37.5%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

Copy link

@efd6 efd6 marked this pull request as ready for review June 23, 2025 23:29
@efd6 efd6 requested a review from a team as a code owner June 23, 2025 23:29
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 merged commit f27ce45 into elastic:main Jun 30, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package gitlab - 2.3.1 containing this change is available at https://epr.elastic.co/package/gitlab/2.3.1/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:gitlab GitLab Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants