Skip to content

gitlab: fix null check condition and field type for production data stream #14424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented Jul 4, 2025

Proposed commit message

Fixing two issues for the production data stream:
- Fix a pipeline error when url.path is null.
- Update the type for params.variables fields from
  keyword to flattened, this change avoids an ingestion
  error when the field contains an object.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chemamartinez chemamartinez self-assigned this Jul 4, 2025
@chemamartinez chemamartinez added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:gitlab GitLab labels Jul 4, 2025
@chemamartinez chemamartinez marked this pull request as ready for review July 4, 2025 14:05
@chemamartinez chemamartinez requested a review from a team as a code owner July 4, 2025 14:05
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 4, 2025
@efd6
Copy link
Contributor

efd6 commented Jul 6, 2025

/test

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package gitlab 👍(3) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
audit 7042.25 4694.84 -2347.41 (-33.33%) 💔
auth 8403.36 5747.13 -2656.23 (-31.61%) 💔
pages 20408.16 10752.69 -9655.47 (-47.31%) 💔
sidekiq 13513.51 8771.93 -4741.58 (-35.09%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chemamartinez

Copy link

@chemamartinez chemamartinez merged commit fdff89e into elastic:main Jul 9, 2025
9 checks passed
@chemamartinez chemamartinez deleted the gitlab-production-fix-ingest-pipeline branch July 9, 2025 12:37
@elastic-vault-github-plugin-prod

Package gitlab - 2.3.2 containing this change is available at https://epr.elastic.co/package/gitlab/2.3.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:gitlab GitLab Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants