Skip to content

gitlab: unify treatment of variables fields #14486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

This fixes the treatment of fields:

  • gitlab.production.params.variables
  • gitlab.production.graphql.variables
  • gitlab.production.params.graphql.variables

I wrongly assumed that they should contain always an object as the docs suggested, and that the [FILTERED] string value that test logs contain was the result of obfuscation during the development.

It turns out that these string values come from the GitLab API so further changes are required to always treat these fields as keyword.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chemamartinez chemamartinez self-assigned this Jul 10, 2025
@chemamartinez chemamartinez added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:gitlab GitLab labels Jul 10, 2025
@chemamartinez chemamartinez marked this pull request as ready for review July 10, 2025 12:02
@chemamartinez chemamartinez requested a review from a team as a code owner July 10, 2025 12:02
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@elasticmachine
Copy link

💚 Build Succeeded

cc @chemamartinez

@chemamartinez chemamartinez merged commit 47d985d into elastic:main Jul 10, 2025
9 checks passed
@chemamartinez chemamartinez deleted the gitlab-unify-variables-fields branch July 10, 2025 13:13
@elastic-vault-github-plugin-prod

Package gitlab - 2.3.3 containing this change is available at https://epr.elastic.co/package/gitlab/2.3.3/

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:gitlab GitLab Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants