-
Notifications
You must be signed in to change notification settings - Fork 474
Fix CPU gauge to just use normalized CPU percentages #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CPU gauge to just use normalized CPU percentages #1458
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
packages/system/changelog.yml
Outdated
- version: "1.1.4" | ||
changes: | ||
- description: Fix issue with normalized CPU gauge | ||
type: enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is more like a "bugfix" than "enhancement".
@jsoriano do you happen to remember this? I don't 🤔 , I guess this is because normalized values were added after the initial dashboards were created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM, besides comment on change type in the changelog
Or maybe that |
So, @andrewkroh , everything is enabled by default save for
|
I think the docs are wrong then. They say:
|
@andrewkroh where are you seeing that? I'm grepping through the repo and can't find it. |
That's from the Metricbeat docs for |
Yes, I think the reason is this one, that normalized values are (or were) disabled by default. |
Yah, key word being were here. We might want to look into just refreshing most of the system dashboards. A lot of this stuff looks really old. |
What does this PR do?
This alters the CPU Usage Gauge to just use normalized values for visualizations, and removes the painless script, which was (incorrectly) dividing the normalized value by the CPU count.
I'd actually like some feedback on this, since I can't figure out why the visualization hasn't always been like this. We've been doing some math cleverness to take the "regular" CPU value and divide it by the CPU count, when this is basically what the
norm.cpu
values do to begin with. I've tested this change and it works fine, but I'm a tad paranoid and I wonder if there's a reason why we haven't been doing this before.Checklist
changelog.yml
file.How to test this PR locally
Pull down, build. Find the CPU Usage gauge In the System Integration Host Details dashboard. Make sure the gauge is populated and the value is correct.