Skip to content

Review the documentation for Prometheus Input Package #14668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Review the documentation for Prometheus Input Package #14668

merged 3 commits into from
Jul 23, 2025

Conversation

alaudazzi
Copy link
Contributor

This PR provides some edits for the Prometheus Input Package.

@alaudazzi alaudazzi self-assigned this Jul 23, 2025
@alaudazzi alaudazzi requested a review from a team as a code owner July 23, 2025 14:11
@alaudazzi alaudazzi added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request labels Jul 23, 2025
@alaudazzi alaudazzi mentioned this pull request Jul 23, 2025
Closed
@alaudazzi alaudazzi changed the title Review the README for Prometheus Input Package Review the documentation for Prometheus Input Package Jul 23, 2025
devamanv
devamanv approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one simple comment.

packages/prometheus_input/docs/README.md Outdated

To scrape metrics from a Prometheus exporter, configure the `hosts` setting to it. The path
to retrieve the metrics from (`/metrics` by default) is appended to the hostname as below:
To collect metrics from a Prometheus exporter, configure the `hosts` setting to it and append the <metrics_path> from which you are collecting your metrics, using the following format:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's still okay to mention (/metrics by default).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@andrewkroh andrewkroh added Integration:prometheus_input Prometheus Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 23, 2025
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @alaudazzi

@alaudazzi alaudazzi merged commit 31d0898 into main Jul 23, 2025
9 checks passed
@alaudazzi alaudazzi deleted the review-prometheus-input-package branch July 23, 2025 16:52
@elastic-vault-github-plugin-prod
Copy link

Package prometheus_input - 0.9.1 containing this change is available at https://epr.elastic.co/package/prometheus_input/0.9.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devamanv devamanv devamanv approved these changes

Assignees

@alaudazzi alaudazzi

Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:prometheus_input Prometheus Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alaudazzi @elasticmachine @devamanv @andrewkroh