[system] Fix condition in handlebar file of security data stream

[janvi-elastic]

Proposed commit message

In System integration with default config, getting an error while saving the integration 
so fix if condition in handlebar file of security data stream.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.
• I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

• Clone integrations repo.
• Install elastic package locally.
• Start elastic stack using elastic-package.
• Move to integrations/packages/system directory.
• Run the following command to run tests.

elastic-package test

[elasticmachine]

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

[elastic-vault-github-plugin-prod]

🚀 Benchmarks report

Package system 👍(0) 💚(2) 💔(1)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
syslog	500000	333333.33	-166666.67 (-33.33%)	💔

To see the full report comment with /test benchmark fullreport

[opauloh]

Hi @janvi-elastic

For the future, Policy testing can be added to catch errors when updating Handlebars: https://github.com/elastic/elastic-package/blob/main/docs/howto/policy_testing.md

For context, a similar error happened to me when editing the handlebars file in the Auditd Manager integration, and then we learned that policy tests spin a Kibana Snapshot to attempt to save an integration policy, which will catch errors with the handlebars. Here is how they are configured in AuditdManager

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: ea08349

History

• 💚 Build #29021 succeeded 24a997b
• 💔 Build #29019 failed bdd08ef

[elastic-vault-github-plugin-prod]

Package system - 2.5.1 containing this change is available at https://epr.elastic.co/package/system/2.5.1/