Skip to content

[CLOUDFLARE_LOGPUSH] Do not convert 0 timestamps in spectrum_event datastream #14682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

StacieClark-Elastic
Copy link
Member

@StacieClark-Elastic StacieClark-Elastic commented Jul 24, 2025

Proposed commit message

Fixed issue in cloudflare_logpush where ConnectTimestamp and DisconnectTimestamp that were set to '0' or 0 were being converted to 0 epoch. ConnectTimestamp and DisconnectTimestamp are set to null if '0', 0 or ''.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Closes #14686

@StacieClark-Elastic StacieClark-Elastic requested a review from a team as a code owner July 24, 2025 20:42
@StacieClark-Elastic StacieClark-Elastic added Integration:cloudflare_logpush Cloudflare Logpush bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jul 24, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

…t datastream where timestamps that were set to '0' or 0 were being converted to 0 epoch. ConnectTimestamp and DisconnectTimestamp are set to null if '0', 0 or ''.
@StacieClark-Elastic StacieClark-Elastic force-pushed the bugfix/cloudflare-logpush-date-processing branch from 2ab19e2 to 01d4401 Compare July 24, 2025 20:48
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package cloudflare_logpush 👍(12) 💚(3) 💔(6)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
magic_ids 12658.23 9708.74 -2949.49 (-23.3%) 💔
page_shield_events 20000 14705.88 -5294.12 (-26.47%) 💔
sinkhole_http 7352.94 5952.38 -1400.56 (-19.05%) 💔
audit 8849.56 5181.35 -3668.21 (-41.45%) 💔
dns 19230.77 16129.03 -3101.74 (-16.13%) 💔
dns_firewall 7142.86 4807.69 -2335.17 (-32.69%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Copy link

@StacieClark-Elastic StacieClark-Elastic merged commit 965215f into elastic:main Jul 24, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package cloudflare_logpush - 1.39.2 containing this change is available at https://epr.elastic.co/package/cloudflare_logpush/1.39.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cloudflare_logpush Cloudflare Logpush Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLOUDFLARE_LOGPUSH] Do not convert 0 timestamps in spectrum_event datastream
3 participants