[AWS] [CloudWatch] Improve description to highlight lastSync option #14733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
force-pushed
the
chore/document-cloudwatch-lastsync-configuration
branch
3 times, most recently
from
5fa8e79 to
bcf7f20
Compare
Kavindu-Dodan
changed the title
Kavindu-Dodan
force-pushed
the
chore/document-cloudwatch-lastsync-configuration
branch
2 times, most recently
from
228082d to
78f12db
Compare
efd6
reviewed
Jul 29, 2025
| @@ -216,7 +216,7 @@ streams: | |||
| required: false | |||
| default: beginning | |||
| show_user: true | |||
| description: Allows user to specify if this input should read log files from the beginning or from the end. | |||
| description: Specify if the input should start reading logs from from the `beginning` (oldest log entry), `end` (newest log entry), or `lastSync` (last successful read timestamp if input ran before). | |||
There was a problem hiding this comment.
Suggested change
| description: Specify if the input should start reading logs from from the `beginning` (oldest log entry), `end` (newest log entry), or `lastSync` (last successful read timestamp if input ran before). | |
| description: Specify if the input should start reading logs from the `beginning` (oldest log entry), `end` (newest log entry), or `lastSync` (last successful read timestamp if input ran before). |
(throughout)
Also consider s/if/whether/.
There was a problem hiding this comment.
Thanks will fix this
There was a problem hiding this comment.
Addressed this with - 91156f0 :)
joecompute
approved these changes
Jul 29, 2025
kaiyan-sheng
approved these changes
Jul 29, 2025
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
Integration:aws_mq
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> # Conflicts: # packages/aws/changelog.yml
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Kavindu-Dodan
force-pushed
the
chore/document-cloudwatch-lastsync-configuration
branch
from
91156f0 to
dd7ed62
Compare
💚 Build Succeeded
History
|
|
|
Package aws - 3.13.4 containing this change is available at https://epr.elastic.co/package/aws/3.13.4/ |
|
Package aws_bedrock - 1.2.3 containing this change is available at https://epr.elastic.co/package/aws_bedrock/1.2.3/ |
|
Package aws_logs - 1.8.2 containing this change is available at https://epr.elastic.co/package/aws_logs/1.8.2/ |
|
Package aws_mq - 0.9.1 containing this change is available at https://epr.elastic.co/package/aws_mq/0.9.1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Improve the description of
start_positionfield withlastSyncconfiguration option.Checklist
changelog.ymlfile.Related issues
Related elastic/beats#43251
Screenshots