Skip to content

[cisco_ftd] Ensure observer zone fields are set #14748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jul 30, 2025

Proposed commit message

  • Ensure Ingress and Egress zone values are set to proper ECS fields
  • This will also allow the network.direction logic to work as intended

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/cisco_ftd
elastic-package test

Note: in order for network.direction to be set properly, the integration needs to be configured with internal_zones and external_zones that match zone names that are seen in the log.

Related issues

- Ensure Ingress and Egress zone values are set to proper ECS fields
- This will also allow the network.direction logic to work as intended
@taylor-swanson taylor-swanson self-assigned this Jul 30, 2025
@taylor-swanson taylor-swanson added Integration:cisco_ftd Cisco FTD bugfix Pull request that fixes a bug issue Team:Integration-Experience labels Jul 30, 2025
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @taylor-swanson

Copy link

@taylor-swanson taylor-swanson marked this pull request as ready for review July 30, 2025 15:13
@taylor-swanson taylor-swanson requested a review from a team as a code owner July 30, 2025 15:13
@andrewkroh andrewkroh added the Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] label Jul 30, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@taylor-swanson taylor-swanson merged commit 0f76101 into elastic:main Jul 31, 2025
9 checks passed
@taylor-swanson taylor-swanson deleted the bug/cisco-ftd-zone-direction branch July 31, 2025 12:59
@elastic-vault-github-plugin-prod

Package cisco_ftd - 3.9.1 containing this change is available at https://epr.elastic.co/package/cisco_ftd/3.9.1/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Jul 31, 2025
- Ensure Ingress and Egress zone values are set to proper ECS fields
- This will also allow the network.direction logic to work as intended
robester0403 added a commit that referenced this pull request Jul 31, 2025
* FIX: changed grok processor to be able to handle any number of spaces between 'server =' and ip address

* FIX: Added change log pr link

* FIX: Added change log pr link

* [Azure AI Foundry] Rename billing dashboard (#14615)

* rename billing dashboard

* [Jamf Protect 3.1.0] New pipelines added and enhancements (#14750)

* Added support for the following new and upcoming events
  * network_connect
  * tcc_modify
  * pty_grant
  * pty_close
* Enhanced existing events (only added fields, no breaking changes)
  * mount
  * remount
  * unmount

* [cisco_ftd] Ensure observer zone fields are set (#14748)

- Ensure Ingress and Egress zone values are set to proper ECS fields
- This will also allow the network.direction logic to work as intended

---------

Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
Co-authored-by: Thijs Xhaflaire <thijsxhaflaire31@hotmail.com>
Co-authored-by: Taylor Swanson <90622908+taylor-swanson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cisco_ftd Cisco FTD Team:Integration-Experience Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cisco_ftd] Observer zone fields are not set by pipeline
4 participants