-
Notifications
You must be signed in to change notification settings - Fork 474
Add custom AWS logs integration for both aws-s3 input and aws-cloudwatch input #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
reviewed
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to have a more generic integration for S3.
packages/aws/data_stream/s3_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/aws/data_stream/s3_logs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
@andrewkroh Thank you for the review! Sorry I just got back to this and addressed your comments. |
andrewkroh
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Integration:aws_logs
Custom AWS Logs
New Integration
Issue or pull request for creating a new integration package.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the AWS package, we have data streams to parse and ingest several service logs, such as s3access, cloudtrail, vpcflow and etc. This PR is to add the raw s3 input into the AWS package as an option when the specific type of service log is not supported in its own data stream.
We decide to create a separate package called
Custom AWS Logs
in integrations and add both aws-s3 input and aws-cloudwatch input options in there. This way, it's aligned with custom logs input, custom TCP/UDP logs input and etc.Checklist
changelog.yml
file.How to test this PR locally
AWS S3
and add itRelated issues
#711