Skip to content

[New Package] Azure Frontdoor Integration #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Feb 9, 2023
Merged

[New Package] Azure Frontdoor Integration #2497

merged 26 commits into from
Feb 9, 2023

Conversation

emnp
Copy link
Contributor

@emnp emnp commented Jan 11, 2022

What does this PR do?

A new package to collect logs from azure frondoor.
Two data-streams;

  • AFD access log
  • AFD waf log

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

# cd integrations/packages/azure_frontdoor
# elastic-package build
# elastic-package stack up -d -v
# eval "$(elastic-package stack shellinit)"
# elastic-package test  -v

Screenshots

azure-frontdoor-overview

@elasticmachine
Copy link

elasticmachine commented Jan 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-02T11:58:06.456+0000

  • Duration: 12 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@emnp emnp changed the title Azure [New Package] Azure Frontdoor Integration Jan 12, 2022
@andrewkroh andrewkroh added the Integration:azure Azure Logs label Feb 11, 2022
@jamiehynds jamiehynds mentioned this pull request Aug 26, 2022
Merged
4 tasks
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus P1llus self-requested a review September 28, 2022 07:47
@P1llus P1llus self-assigned this Sep 28, 2022
@P1llus
Copy link
Member

P1llus commented Sep 28, 2022

Hello @emnp

Sorry for the delayed response on this! Are you still open to finalize the package together with me as a review?

@botelastic
Copy link

botelastic bot commented Oct 28, 2022

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 28, 2022
@botelastic
Copy link

botelastic bot commented Nov 27, 2022

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Nov 27, 2022
@emnp
Copy link
Contributor Author

emnp commented Nov 28, 2022

Hi @P1llus, sorry for the delay. Can I continue to work on this PR?

@P1llus
Copy link
Member

P1llus commented Nov 28, 2022

Absolutely @emnp . I will try to merge your other PR soon as well, sorry for the delay!

@P1llus P1llus reopened this Nov 28, 2022
@botelastic botelastic bot removed the Stalled label Nov 28, 2022
@emnp
Copy link
Contributor Author

emnp commented Nov 28, 2022

Absolutely @emnp . I will try to merge your other PR soon as well, sorry for the delay!

Hi @P1llus, I just updated the stuff like the readme file as per documentation guidelines, kibana version up to 8 in manifest.yml and change IPs in the test log to allowed IPs. Please take a look.

@P1llus
Copy link
Member

P1llus commented Nov 29, 2022

/test

@ShourieG
Copy link
Contributor

/test

@kcreddy
Copy link
Contributor

kcreddy commented Feb 2, 2023

/test

kcreddy

This comment was marked as duplicate.

Sign in to view

kcreddy
kcreddy approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made based on the review suggestions. Once @P1llus gives thumbsup, can be merged

@kcreddy
Copy link
Contributor

kcreddy commented Feb 2, 2023

/test

@kcreddy
Copy link
Contributor

kcreddy commented Feb 2, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Feb 2, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 91.667% (22/24) 👎 -4.487
Lines 100.0% (288/288) 💚
Conditionals 100.0% (0/0) 💚

@kcreddy
Copy link
Contributor

kcreddy commented Feb 2, 2023

/test

P1llus
P1llus approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from what I can see

@P1llus
Copy link
Member

P1llus commented Feb 3, 2023

@emnp we have added the last changes needed before a merge, just wanted to check in with you that this is okay?

Sorry for the unusual long waiting time here!

@kcreddy kcreddy added the v8.7.0 label Feb 6, 2023
@kcreddy kcreddy self-assigned this Feb 9, 2023
@kcreddy kcreddy merged commit bb0f717 into elastic:main Feb 9, 2023
@kcreddy kcreddy added New Integration Issue or pull request for creating a new integration package. Integration:azure_frontdoor Azure Frontdoor (Community supported) and removed Integration:azure Azure Logs labels Feb 9, 2023
@elasticmachine
Copy link

Package azure_frontdoor - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=azure_frontdoor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG left review comments

@P1llus P1llus P1llus approved these changes

@kcreddy kcreddy kcreddy approved these changes

Assignees

@P1llus P1llus

@kcreddy kcreddy

Labels
Integration:azure_frontdoor Azure Frontdoor (Community supported) New Integration Issue or pull request for creating a new integration package. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emnp @elasticmachine @P1llus @ShourieG @kcreddy @andrewkroh