-
Notifications
You must be signed in to change notification settings - Fork 474
Add ssl.certificate_authorities configuration #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssl.certificate_authorities configuration #2613
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
title: SSL Certificate Authorities | ||
multi: true | ||
required: false | ||
show_user: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not set here a default value, though it is mostly standard - /var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt
(for kubernetes.state_*
datasets) just to avoid getting ssl.certificate_authorities
setting in final config.
@ChrsMark @MichaelKatsoulis is there any better way to handle it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leaving it blank is just fine since you have the ifs
in the handlebars file (stream.yml.hbs
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @tetianakravchenko ! Could you maybe move node
and namespace
settings under advanced settings too? This would make the basic setting panel more compact.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
…egrations into k8s-add-ssl-fields
Thank you @tetianakravchenko ! It looks good now but there are some conflicts to be resolved. |
Signed-off-by: Tetiana Kravchenko tetiana.kravchenko@elastic.co
What does this PR do?
To support Openshift k8s package is missing some configuration settings - for more details - https://github.com/elastic/observability-docs/pull/1498/files and https://github.com/elastic/beats/pull/30054/files
for
kubernetes.state_*
:no way to set:
to all datastreams that connnect to
https://${env.NODE_NAME}:10250
(likekubernetes.container
) no way to set:Checklist
changelog.yml
file.How to test this PR locally
Related issues
Screenshots
For

kubernetes.state_*
resources:for kubernetes.container:
