Add support for azure logs integration #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Expand to view the summary
Build stats
Steps errors
Expand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
narph
changed the title
|
Pinging @elastic/integrations (Team:Integrations) |
exekias
reviewed
Nov 2, 2020
| @@ -0,0 +1,45 @@ | |||
| --- | |||
| description: Pipeline for parsing azure activity logs. | |||
There was a problem hiding this comment.
I see this file is reused across all datasets, but because of implementation it's not "shared" anymore, right? I wonder what would be the best way to handle this
There was a problem hiding this comment.
Maybe we can use YAML references or something that are resolved at either package build time (so the file is duplicated) or in Kibana at runtime when the package is consumed. Or maybe a symlink might work too, although that might be problematic for Windows package developers?
Let's move this discussion to the package-spec repo so we don't hold up this PR? Depending on the outcome we can come back and update all packages with shared assets like this one.
exekias
reviewed
Nov 2, 2020
exekias
reviewed
Nov 2, 2020
Since this package will accommodate both logs ( including AD logs) and metrics I suggest calling it Any additional packages that might come up later (e.g. for billing, app insights) can be more specific, like |
andrewkroh
added
Integration:azure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for azure logs integration
ex log:
Dashboards look good.