-
Notifications
You must be signed in to change notification settings - Fork 474
[Kafka] New custom input package #2741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/integrations (Team:Integrations) |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Should work just fine, but I want to see if we can add some kafka system tests, looking for some proper docker images to do this first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me. I think we still need system tests here in order to release it as GA right?
About the owner, not sure if it's appropriate to change right now but I think eventually elastic/obs-service-integrations
should own this.
+1 to this, I think we shouldn't have packages owned by integrations as this is becoming confusing, see #3202 |
🌐 Coverage report
|
Just trying to clarify. This new package is developed by security team but not owned by them? |
/test |
@P1llus the changes looks good to me. The name "custom kafka logs" confused me, where I thought as the logs of kafka broker. Where as this is actually just referring to all the messages in "kafka topic". |
What does this PR do?
This adds custom Kafka input package, allowing users to ingest data from kafka using our input, with their own pipelines.
This has been built in the same format and principle as our other input packages.
Checklist
changelog.yml
file.