Skip to content

Pass the SSL configs entered in the UI down to agent config #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2022
Merged

Pass the SSL configs entered in the UI down to agent config #2792

merged 2 commits into from
Mar 9, 2022

Conversation

lalit-satapathy
Copy link
Contributor

Pass the SSL configs entered in the UI down to agent config for the following metricsets: broker, consumergroup & partition.

Bumping the version to 1.2.2

Closes #2750
Redo of PR #2785, which will be closed.

What does this PR do?

Earlier SSL configs were not passed down to the metricset. Fixed it.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Tested the changes using elastic-package build and run. The new agent policy with ssl entered from the UI.

  • id: kafka/metrics-kafka.partition-4fec773e-840d-470c-ae45-3bbcd1aff871
    data_stream:
    dataset: kafka.partition
    type: metrics
    metricsets:
    - partition
    period: 10s
    hosts:
    - 'localhost:9092'
    ssl.certificate: cert1
    ssl.certificate_authorities: auth1
    ssl.key: key1

@lalit-satapathy
Pass the SSL configs entered in the UI down to agent config for the f…
18912b6 
…ollowing metricsets: broker, consumergroup & partition.

Bumping the version to 1.2.1

Closes elastic#2750
@lalit-satapathy lalit-satapathy requested a review from a team as a code owner March 9, 2022 07:25
@lalit-satapathy lalit-satapathy mentioned this pull request Mar 9, 2022
Closed
4 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 9, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-09T07:18:52.105Z&rangeTo=2022-03-09T07:38:52.105Z&transactionName=BUILD Ingest-manager/integrations/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=2300098701c2a221d13c156975b8b719&transactionId=066aae33451f4d96)

Expand to view the summary

Build stats

  • Start Time: 2022-03-09T07:28:52.105+0000

  • Duration: 12 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

MichaelKatsoulis
MichaelKatsoulis approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalit-satapathy lalit-satapathy merged commit 5d5a8c0 into elastic:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kafka Metrics Integration is not using ssl.certificate_authorities, ssl.certificate and ssl.key
3 participants
@lalit-satapathy @elasticmachine @MichaelKatsoulis