Skip to content

[azure] Added forwarded tag for Azure logs #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 29, 2022
Merged

[azure] Added forwarded tag for Azure logs #2822

merged 14 commits into from
Mar 29, 2022

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Mar 14, 2022

What does this PR do?

Added forwarded tags for Azure logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

LaZyDK added 7 commits March 14, 2022 09:03
Added forwarded tag for Azure audit logs
Added forwarded tag for Azure activity logs
Added forwarded tag for Azure Eventhub logs
Added forwarded tag for Azure platform logs
Added forwarded tag for Azure signin logs
Added forwarded tag for Azure springcloud logs
@LaZyDK LaZyDK requested a review from a team as a code owner March 14, 2022 08:17
@elasticmachine
Copy link

elasticmachine commented Mar 14, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-29T11:04:41.800+0000

  • Duration: 11 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 85
Skipped 0
Total 85

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh added enhancement New feature or request Integration:azure Azure Logs labels Mar 14, 2022
@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh changed the title Added forwarded tag for Azure logs [azure] Added forwarded tag for Azure logs Mar 14, 2022
@andrewkroh
Copy link
Member

Hi @LaZyDK, can you add an entry to the changelog.yml file and bump the version in the manifest.yml to match.

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 16, 2022

@andrewkroh Done :)

@andrewkroh
Copy link
Member

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what CI testing says. There might be some expected test files that need updated to include new tag (e.g. cd packages/azure && elastic-package test pipeline --generate).

@andrewkroh
Copy link
Member

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Requires review from @elastic/obs-cloud-monitoring.

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello sorry for the late response here! @LaZyDK Could you fix the conflict please? Thank you!!

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 29, 2022

It has been done.

@andrewkroh andrewkroh merged commit 510bb1c into elastic:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:azure Azure Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants