Skip to content

[Multiple Packages] adding change to forwarded tag template to multiple packages #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Apr 13, 2022

What does this PR do?

The format used to check if publisher_pipeline.disable_host: true should be used is incorrect

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus added bug Something isn't working, use only for issues Team:Security-External Integrations Team:Service-Integrations Label for the Observability Service Integrations team labels Apr 13, 2022
@P1llus P1llus requested review from a team as code owners April 13, 2022 14:51
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member Author

P1llus commented Apr 13, 2022

Added a fix for timestamp field mapping as well for the github package to get the CI to pass, they are usually added to base-fields.yml rather than ecs.yml for now.

@andrewkroh
Copy link
Member

The format used to check if add_host_metadata processor should run or not, for some packages, was wrong

It doesn't affect add_host_metadata. It looks like it affects whether publisher_pipeline.disable_host: true is added.

@@ -1,5 +1,3 @@
- name: "@timestamp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be preferred, but it's not supported because of elastic/elastic-package#749.

@elasticmachine
Copy link

elasticmachine commented Apr 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-13T14:52:13.309+0000

  • Duration: 17 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 111
Skipped 0
Total 111

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants