Skip to content

Improve s3 integration tile information #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2022
Merged

Improve s3 integration tile information #3240

merged 3 commits into from
May 2, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 29, 2022

What does this PR do?

This PR changes s3 integration tile's title and description to better explain what this integration does.
Also several services in AWS should be called Amazon XXX instead of AWS XXX. For example, S3, RDS, EC2 and etc.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screen Shot 2022-04-29 at 2 46 41 PM

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner April 29, 2022 20:47
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 29, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-02T17:03:00.007+0000

  • Duration: 26 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 328
Skipped 0
Total 328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 29, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.123
Classes 91.667% (11/12) 👎 -5.123
Methods 82.439% (169/205) 👎 -5.841
Lines 92.66% (2083/2248) 👍 3.76
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng merged commit 9943684 into elastic:main May 2, 2022
@kaiyan-sheng kaiyan-sheng deleted the update_tile_names branch May 2, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "AWS S3" integration tile details to clearly explain the usage of this integration
3 participants