-
Notifications
You must be signed in to change notification settings - Fork 474
auditd: migrate tile_map to map object #3246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only downside is that it appears we need to drop support for 7.x since the conversion process needs Kibana 8.0.
I think it would be good to get a review from a Kibana dashboard expert too. @flash1293, would you be able to look this over?
packages/auditd/kibana/dashboard/auditd-dfbb49f0-0a0f-11e7-8a62-2d05eaaac5cb.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for another review before merging.
Yes. That was the plan, since I'll do the remainders as a single PR, so I want to make sure it only needs to be done once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took me a bit to set up my environment to test this, but ultimately I managed and this LGTM. The dashboard can be converted to by-value / Lens but this can also be handled in a separate PR.
@flash1293 Can you point me to docs for how to make that change? I will take that on after the maps migration. |
@efd6 Check out the best practices doc - let me know in case some key information is missing, I'm definitely making assumptions about prior Kibana experience that might be incorrect for the targeted audience. |
@flash1293 Thanks |
What does this PR do?
Migrates the map visualisation to from tile_map to map object.
(This PR is partially to test the waters — if it's fine I'll take on the remaining SEI migrations)
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots