Skip to content

auditd: migrate tile_map to map object #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 2, 2022

What does this PR do?

Migrates the map visualisation to from tile_map to map object.

(This PR is partially to test the waters — if it's fine I'll take on the remaining SEI migrations)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Please confirm that I have correctly adjusted the kibana version constraint.

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 requested a review from a team as a code owner May 2, 2022 06:43
@efd6 efd6 self-assigned this May 2, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-03T00:11:37.188+0000

  • Duration: 14 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 2, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.21
Classes 100.0% (1/1) 💚 3.21
Methods 100.0% (15/15) 💚 11.72
Lines 97.985% (2140/2184) 👍 9.085
Conditionals 100.0% (0/0) 💚

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only downside is that it appears we need to drop support for 7.x since the conversion process needs Kibana 8.0.

I think it would be good to get a review from a Kibana dashboard expert too. @flash1293, would you be able to look this over?

@andrewkroh andrewkroh requested a review from flash1293 May 2, 2022 14:00
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for another review before merging.

@efd6
Copy link
Contributor Author

efd6 commented May 3, 2022

Yes. That was the plan, since I'll do the remainders as a single PR, so I want to make sure it only needs to be done once.

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit to set up my environment to test this, but ultimately I managed and this LGTM. The dashboard can be converted to by-value / Lens but this can also be handled in a separate PR.

@efd6 efd6 merged commit 7e3cf07 into elastic:main May 3, 2022
@efd6
Copy link
Contributor Author

efd6 commented May 3, 2022

@flash1293 Can you point me to docs for how to make that change? I will take that on after the maps migration.

@flash1293
Copy link
Contributor

@efd6 Check out the best practices doc - let me know in case some key information is missing, I'm definitely making assumptions about prior Kibana experience that might be incorrect for the targeted audience.

@efd6
Copy link
Contributor Author

efd6 commented May 4, 2022

@flash1293 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:auditd Auditd Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants