-
Notifications
You must be signed in to change notification settings - Fork 474
fix ECS schema on system/auth package #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit fixes the ECS schema on system/auth package. Fixes elastic#3051
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test that's using this schema? Was it failing before?
packages/system/data_stream/auth/_dev/test/pipeline/test-auth.log-expected.json
Outdated
Show resolved
Hide resolved
It's kinda the other way around, tests are being introduced and are failing because some packages don't fully comply with the ECS: elastic/elastic-package#771 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a changelog entry.
Done on ce5e909 |
@belimawr you also need to update the version in the manifest. For next time you can also use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
What does this PR do?
This commit fixes the ECS schema on system/auth package.
Checklist
changelog.yml
file.## Author's ChecklistHow to test this PR locally
Related issues
## Screenshots