Skip to content

cisco_{asa,ftd}: fix syslog priority handling #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 21, 2022

What does this PR do?

This fixes the mapping of syslog priority and its derived values and their extraction.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_asa Cisco ASA labels Jun 21, 2022
@efd6 efd6 self-assigned this Jun 21, 2022
@efd6 efd6 force-pushed the 3507-cisco_asa branch from 8e64ee6 to d647e6e Compare June 21, 2022 10:39
@efd6 efd6 marked this pull request as ready for review June 21, 2022 10:40
@efd6 efd6 requested a review from a team as a code owner June 21, 2022 10:40
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Jun 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-22T01:40:26.742+0000

  • Duration: 18 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 48
Skipped 0
Total 48

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 21, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.464
Classes 100.0% (2/2) 💚 3.464
Methods 97.143% (34/35) 👍 8.297
Lines 64.839% (2176/3356) 👎 -25.066
Conditionals 100.0% (0/0) 💚

@efd6 efd6 changed the title cisco_asa: fix syslog priority handling cisco_{asa,ftd}: fix syslog priority handling Jun 22, 2022
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

All of the syslog messages I've seen so far for ASA and FTD have not used the odd <14.2> format, just the standard format that you've changed it to here (<165>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:cisco_asa Cisco ASA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants