Skip to content

Add processors and tags to all system data streams #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

Fix for #2865
This adds a little drop-down config that adds processors and tags fields to all events in the system integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@fearful-symmetry fearful-symmetry added enhancement New feature or request Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] labels Jun 22, 2022
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner June 22, 2022 17:21
@fearful-symmetry fearful-symmetry requested a review from cmacknz June 22, 2022 17:21
@fearful-symmetry fearful-symmetry self-assigned this Jun 22, 2022
@fearful-symmetry fearful-symmetry requested a review from kvch June 22, 2022 17:21
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

elasticmachine commented Jun 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-22T18:23:44.309+0000

  • Duration: 17 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 270
Skipped 0
Total 270

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 3.432
Classes 100.0% (4/4) 💚 3.432
Methods 59.74% (46/77) 👎 -29.169
Lines 98.782% (2676/2709) 👍 8.836
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member

cmacknz commented Jun 23, 2022

Seems a little weird to link to the filebeat processor documentation for an agent feature, but we do it everywhere in integrations it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants