Skip to content

[Security Rules] Update security rules package to v8.1.1 #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

terrancedejesus
Copy link
Contributor

@terrancedejesus terrancedejesus commented Jun 22, 2022

What does this PR do?

Update the Security Rules package to version 8.1.1.
Autogenerated from commit https://github.com/elastic/detection-rules/tree/af4bf14723a7a2b4adf7ba16e2087ef31789e0c4

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • Install the most recently release security rules in the Detection Engine
  • Install the package
  • Confirm the update is available in Kibana. Click "Update X rules" or "Install X rules"
  • Look at the changes made after the install and confirm they are consistent

How to test this PR locally

  • Perform the above checklist, and use package-storage to build EPR from source

Related issues

@terrancedejesus terrancedejesus requested a review from a team as a code owner June 22, 2022 20:08
@terrancedejesus terrancedejesus self-assigned this Jun 22, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-23T19:29:18.751+0000

  • Duration: 13 min 17 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@terrancedejesus terrancedejesus added trade-artifacts Issues related to TRADE artifact building and releasing v8.3.0 labels Jun 22, 2022
Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
@@ -3,7 +3,7 @@
"author": [
"Elastic"
],
"description": "This rule is triggered when indicators from the Threat Intel Filebeat module (v7.x) has a match against local file or network observations.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try to see why this name changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the 7.x was deprecated in January. This has the ID of dc672cb7-d5df-4d1f-a6d7-0841b1caafb9. The only reference to the 8.x rule I can find is for rule tuning. with the ID 699e9fdb-b77c-4c01-995c-1c15019b9c43. Somewhere along this, it almost seems as if it is saying it is a change rather than an entirely different rule.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that rule deprecation was not backported on purpose therefore 7x still exists in 7.16. Since we do 7.x series first, this rule exists in Integrations repository at the time of this PR. I am not sure why it thinks this file has a name change though as the file name and rule ID are entirely different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to timing, I am going to move this question/investigation to an actual bug issue within Detection Rules since we now have evidence it is repetitive. While the potential bug itself is not harmful to these integrations, it could have bigger implications in later releases and should be investigated and solved.

Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question then LGTM 👍

@terrancedejesus terrancedejesus merged commit ee2a96d into main Jun 23, 2022
@terrancedejesus terrancedejesus deleted the detection-rules/8.1.1-af4bf147 branch June 23, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trade-artifacts Issues related to TRADE artifact building and releasing v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants