-
Notifications
You must be signed in to change notification settings - Fork 474
[Security Rules] Update security rules package to v8.1.1 #3565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
@@ -3,7 +3,7 @@ | |||
"author": [ | |||
"Elastic" | |||
], | |||
"description": "This rule is triggered when indicators from the Threat Intel Filebeat module (v7.x) has a match against local file or network observations.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you try to see why this name changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the 7.x was deprecated in January. This has the ID of dc672cb7-d5df-4d1f-a6d7-0841b1caafb9
. The only reference to the 8.x rule I can find is for rule tuning. with the ID 699e9fdb-b77c-4c01-995c-1c15019b9c43
. Somewhere along this, it almost seems as if it is saying it is a change rather than an entirely different rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly enough - This happened during the last 8 series integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that rule deprecation was not backported on purpose therefore 7x still exists in 7.16. Since we do 7.x series first, this rule exists in Integrations repository at the time of this PR. I am not sure why it thinks this file has a name change though as the file name and rule ID are entirely different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to timing, I am going to move this question/investigation to an actual bug issue within Detection Rules since we now have evidence it is repetitive. While the potential bug itself is not harmful to these integrations, it could have bigger implications in later releases and should be investigated and solved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 question then LGTM 👍
What does this PR do?
Update the Security Rules package to version 8.1.1.
Autogenerated from commit https://github.com/elastic/detection-rules/tree/af4bf14723a7a2b4adf7ba16e2087ef31789e0c4
Checklist
I have verified that all data streams collect metrics or logs.changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
package-storage
to build EPR from sourceRelated issues