Skip to content

[Azure Metrics] Move container_registry metrics from beats to integrations #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2022
Merged

[Azure Metrics] Move container_registry metrics from beats to integrations #3629

merged 3 commits into from
Jul 8, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jun 29, 2022 •
edited
Loading

What does this PR do?

This PR is to move lightweight module configuration from Metricbeat into integrations.

Switch from "container_registry" to "monitor" metricset, add the metrics configuration from beats, and add an ingest pipeline to set the expected field names (azure. container_registry.* instead of azure.metrics.*).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@zmoog zmoog self-assigned this Jun 29, 2022
@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jun 29, 2022
@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-06T14:31:13.486+0000

  • Duration: 17 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 29, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.778
Classes 100.0% (0/0) 💚 2.778
Methods 53.333% (16/30) 👎 -36.539
Lines 100.0% (0/0) 💚 8.701
Conditionals 100.0% (0/0) 💚

@zmoog
Copy link
Contributor Author

zmoog commented Jun 30, 2022

We're probably good to go; it just needs some testing.

@zmoog
Move container_registry metrics from beats to integrations
5f659dc 
Switch from "container_registry" to "monitor" metricset, add the
metrics configuration from beats, and add an ingest pipeline to
set the expected field names (`container_registry.*` instead
of `azure.metrics.*`).
@zmoog zmoog force-pushed the rm-lw-mods-az-container_registry branch from 6a0ecf6 to 5f659dc Compare June 30, 2022 14:49
@zmoog zmoog marked this pull request as ready for review June 30, 2022 15:46
@zmoog zmoog requested a review from a team as a code owner June 30, 2022 15:46
@zmoog zmoog mentioned this pull request Jul 1, 2022
Merged
4 tasks
@zmoog zmoog changed the title Move container_registry metrics from beats to integrations [Azure] Move container_registry metrics from beats to integrations Jul 1, 2022
@zmoog zmoog changed the title [Azure] Move container_registry metrics from beats to integrations [Azure Metrics] Move container_registry metrics from beats to integrations Jul 1, 2022
kaiyan-sheng
kaiyan-sheng reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you also update the sample_event.json file please?

kaiyan-sheng
kaiyan-sheng approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the sample_event.json!! LGTM!

@tommyers-elastic tommyers-elastic merged commit adbfb7a into elastic:main Jul 8, 2022
@zmoog zmoog deleted the rm-lw-mods-az-container_registry branch July 18, 2022 12:48
@zmoog
Copy link
Contributor Author

zmoog commented Jul 18, 2022

@tommyers-elastic, thank you, I missed that one 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@zmoog zmoog

Labels
enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lightweight modules from azure_metrics container_registry data stream
4 participants
@zmoog @elasticmachine @kaiyan-sheng @tommyers-elastic