Skip to content

[IBM MQ] Add 'qmgr' Data Stream to IBM MQ package #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 3, 2022
Merged

[IBM MQ] Add 'qmgr' Data Stream to IBM MQ package #3637

merged 10 commits into from
Aug 3, 2022

Conversation

harnish-crest
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Added 1 data stream (Queue Manager performance metrics).
  • Added data collection logic for the data streams.
  • Added the ingest pipeline for the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
  • Added dashboards and visualizations.
  • Added system test cases for the data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/ibmmq directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

ibmmq-calls
ibmmq-messages
ibmmq-subscriptions

@harnish-crest harnish-crest marked this pull request as draft July 1, 2022 13:35
@harnish-crest harnish-crest mentioned this pull request Jul 1, 2022
Merged
4 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 1, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-03T12:26:23.630+0000

  • Duration: 21 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Jul 1, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.868
Classes 100.0% (2/2) 💚 2.868
Methods 100.0% (20/20) 💚 10.751
Lines 98.904% (451/456) 👍 8.297
Conditionals 100.0% (0/0) 💚

@yug-rajani yug-rajani added enhancement New feature or request Integration:ibmmq IBM MQ Team:Service-Integrations Label for the Observability Service Integrations team labels Jul 2, 2022
@yug-rajani yug-rajani linked an issue Jul 2, 2022 that may be closed by this pull request
Create IBM MQ package #620
Closed
8 tasks
yug-rajani
yug-rajani reviewed Jul 4, 2022
View reviewed changes
yug-rajani
yug-rajani suggested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes

@harnish-crest harnish-crest requested a review from yug-rajani July 4, 2022 07:38
@yug-rajani
Copy link
Contributor

/test

yug-rajani
yug-rajani approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@yug-rajani yug-rajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-crest
update categories of package
0d9f44d
@harnish-crest
update README.md
6274fd0
@harnish-crest
update manifest.yml
aadb195
@harnish-crest
Merge branch 'main' of https://github.com/harnish-crest/integrations …
850019a 
…into package_ibmmq_qmgr

Conflicts:
	packages/ibmmq/_dev/build/build.yml
	packages/ibmmq/_dev/build/docs/README.md
	packages/ibmmq/_dev/deploy/docker/docker-compose.yml
	packages/ibmmq/_dev/deploy/variants.yml
	packages/ibmmq/changelog.yml
	packages/ibmmq/docs/README.md
	packages/ibmmq/img/ibmmq.svg
	packages/ibmmq/manifest.yml
@harnish-crest harnish-crest marked this pull request as ready for review July 18, 2022 09:24
@harnish-crest harnish-crest requested a review from a team as a code owner July 18, 2022 09:24
@yug-rajani yug-rajani requested a review from ritalwar July 18, 2022 09:40
ritalwar
ritalwar requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the group fields which contain only single field and use them directly wherever possible and also specify unit for the fields if applicable.

@harnish-crest harnish-crest requested a review from ritalwar July 28, 2022 17:45
ritalwar
ritalwar previously approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritalwar ritalwar dismissed their stale review August 1, 2022 09:13

Need to review one more time.

@harnish-crest harnish-crest requested a review from ritalwar August 2, 2022 05:42
ritalwar
ritalwar requested changes Aug 2, 2022
View reviewed changes
packages/ibmmq/data_stream/qmgr/fields/fields.yml Outdated
description: Interval total destructive get byte count.
- name: count
type: long
description: Interval total destructive get count.
Copy link
Contributor

@ritalwar ritalwar Aug 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description should be more clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have referred this official doc descriptions. Please have a look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use separator get - count as in link you mentioned.

@harnish-crest harnish-crest requested a review from ritalwar August 3, 2022 06:21
ritalwar
ritalwar requested changes Aug 3, 2022
View reviewed changes
packages/ibmmq/data_stream/qmgr/fields/fields.yml Outdated
description: Interval total destructive get byte count.
- name: count
type: long
description: Interval total destructive get count.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use separator get - count as in link you mentioned.

@harnish-crest harnish-crest requested a review from ritalwar August 3, 2022 12:44
@yug-rajani yug-rajani merged commit 797649c into elastic:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yug-rajani yug-rajani yug-rajani approved these changes

@ritalwar ritalwar ritalwar approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@harnish-crest harnish-crest

Labels
enhancement New feature or request Integration:ibmmq IBM MQ Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create IBM MQ package
4 participants
@harnish-crest @elasticmachine @yug-rajani @ritalwar