[Cloud Posture] add benchmark id to rule template #3654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
/test |
1 task
orouz
commented
Jul 11, 2022
packages/cloud_security_posture/data_stream/findings/manifest.yml
Outdated
Show resolved
Hide resolved
kfirpeled
requested changes
Jul 12, 2022
kfirpeled
approved these changes
Jul 12, 2022
| description: Check CIS Benchmark compliance | ||
| description: | | ||
| Check CIS Benchmark compliance | ||
| ###### only a single benchmark can be enabled. default is K8s CIS. |
There was a problem hiding this comment.
nit today's markdown makes the text in capital letters, however, it can be changed at some point - consider changing it to Only a single benchmark can be enabled. Default is K8s CIS. - just to be on the safe side
| description: Check CIS Amazon Benchmark compliance | ||
| description: | | ||
| Check CIS Amazon Benchmark compliance | ||
| ###### only a single benchmark can be enabled. default is K8s CIS. |
kfirpeled
reviewed
Jul 12, 2022
| description: Check CIS Benchmark compliance | ||
| description: | | ||
| Check CIS Benchmark compliance | ||
| ###### only a single benchmark can be enabled. default is K8s CIS. |
There was a problem hiding this comment.
Suggested change
| ###### only a single benchmark can be enabled. default is K8s CIS. | |
| ###### Only a single benchmark can be enabled. Default is K8s CIS. |
| description: Check CIS Amazon Benchmark compliance | ||
| description: | | ||
| Check CIS Amazon Benchmark compliance | ||
| ###### only a single benchmark can be enabled. default is K8s CIS. |
There was a problem hiding this comment.
Suggested change
| ###### only a single benchmark can be enabled. default is K8s CIS. | |
| ###### Only a single benchmark can be enabled. Default is K8s CIS. |
|
/test |
5 tasks
|
/test |
kfirpeled
added
the
Team:Cloud Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this PR uses the newly introduced
benchmark.idproperty and assigns every existing rule templates to usecis_k8sas its benchmark id.when EKS rule templates are introduced, they should be added with their benchmark id property set to
cis_eksChecklist
I have verified that all data streams collect metrics or logs.changelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.How to test this PR locally
xpack.fleet.registryUrl: 'http://localhost:8080'inkibana.dev.ymleksrulecis_k8sruleidso it's unique (replace a single char)benchmark.idtocis_ekselastic-package build && elastic-package stack up -v -s package-registry92forcis_k8sand1forcis_eksexample:
