Skip to content

[AWS] check if event.original exists before copying message field #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[AWS] check if event.original exists before copying message field #3682

merged 2 commits into from
Jul 13, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 11, 2022

What does this PR do?

Upstream event forwarders like Logstash can add their event.original field so we should add a check to see if event.original exists before copying message field to event.original.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review July 11, 2022 19:03
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner July 11, 2022 19:03
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 11, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-11T19:16:40.397+0000

  • Duration: 35 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 332
Skipped 0
Total 332

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.278
Classes 91.667% (11/12) 👎 -5.278
Methods 82.692% (172/208) 👎 -6.77
Lines 92.894% (2157/2322) 👍 2.692
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but is there a way we can put these 2 repeated processors in a separate shared pipeline to avoid repetition everywhere?

@kaiyan-sheng
Copy link
Contributor Author

LGTM - but is there a way we can put these 2 repeated processors in a separate shared pipeline to avoid repetition everywhere?

Thanks for the review and good question! These two processors are used per data stream, but I don't think we can define a shared pipeline at the package (aws integration) level so data streams under that package can all use it hmmmm

@kaiyan-sheng kaiyan-sheng merged commit fa07f3e into elastic:main Jul 13, 2022
@kaiyan-sheng kaiyan-sheng deleted the aws_event_original branch July 13, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants