Enancement to support Oracle sysmetrics tablespace and performance metrics #3759

agithomas · 2022-07-19T13:37:32Z

Enhancement

What does this PR do?

Enhacement to capture performance, tablespace and sysmetrics metric data for Oracle database

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

…trics

elasticmachine · 2022-07-19T13:51:04Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-26T06:19:16.498+0000
Duration: 16 min 27 sec

Test stats 🧪

Test	Results
Failed	0
Passed	14
Skipped	0
Total	14

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

agithomas · 2022-07-20T03:55:42Z

/test

elasticmachine · 2022-07-20T07:24:23Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`1/1`)	💚
Files	100.0% (`1/1`)	💚 2.988
Classes	100.0% (`1/1`)	💚 2.988
Methods	86.957% (`20/23`)	👎 -2.758
Lines	89.13% (`164/184`)	👎 -2.292
Conditionals	100.0% (`0/0`)	💚

packages/oracle/data_stream/performance/elasticsearch/ingest_pipeline/default.yml

packages/oracle/manifest.yml

packages/oracle/kibana/visualization/oracle-08e34a30-06a4-11ed-9b66-bb6ba8b5cf1d.json

packages/oracle/data_stream/performance/elasticsearch/ingest_pipeline/default.yml

packages/oracle/_dev/build/docs/README.md

packages/oracle/changelog.yml

packages/oracle/data_stream/performance/fields/fields.yml

packages/oracle/data_stream/tablespace/fields/fields.yml

packages/oracle/manifest.yml

muthu-mps · 2022-07-21T12:32:15Z

Please consider adding dashboard img files for new datastreams.

…dback

agithomas · 2022-07-22T06:24:00Z

@elastic/security-external-integrations , can you please help by reviewing the PR?

packages/oracle/data_stream/tablespace/agent/stream/stream.yml.hbs

packages/oracle/data_stream/tablespace/elasticsearch/ingest_pipeline/default.yml

packages/oracle/data_stream/sysmetric/manifest.yml

ishleenk17 · 2022-07-22T07:22:09Z

Screenshot of the newer dashboards that have been added should be added to the img folder

packages/oracle/kibana/dashboard/oracle-9e19fb00-08e1-11ed-9abf-15e60715cfab.json

packages/oracle/_dev/build/docs/README.md

packages/oracle/data_stream/performance/fields/fields.yml

packages/oracle/data_stream/tablespace/elasticsearch/ingest_pipeline/default.yml

agithomas · 2022-07-25T20:00:28Z

@elastic/security-external-integrations , all the fixes based on review comments are applied. Kindly help with the PR approval.

packages/oracle/data_stream/performance/fields/fields.yml

packages/oracle/data_stream/sysmetric/manifest.yml

packages/oracle/data_stream/performance/fields/fields.yml

agithomas · 2022-07-26T05:19:11Z

Screenshot of the newer dashboards that have been added should be added to the img folder

Added the images

agithomas · 2022-07-26T05:19:35Z

Please consider adding dashboard img files for new datastreams.

Done

packages/oracle/manifest.yml

muthu-mps · 2022-07-26T05:34:26Z

Can you please correct the name of the visualisation. Top 10 session counts by hosts (Copy) and replace the image.

agithomas · 2022-07-26T06:22:54Z

Can you please correct the name of the visualisation. Top 10 session counts by hosts (Copy) and replace the image.

Fixed.

Enancement to support Oracle sysmetrics tablespace and performance me…

593ade5

…trics

agithomas requested a review from a team as a code owner July 19, 2022 13:37

Fixed the ecs version

1aa59a7

agithomas added 3 commits July 19, 2022 13:54

Formatting done

2ae48f1

removed unwanted comments

f7779c7

Removed system test files. updated readme document

4ec870e

agithomas added 9 commits July 20, 2022 04:17

Modified the readme

e1e80e4

Checking in the modified docs-readme

181eee5

Documentation improvements

b069ac0

Fixed dashboard bugs

c2263e6

Fixed visualization bugs

2e5c6f0

Dashboard issue fix

8c40588

Removed unwanted visualizations

d42699a

Attempt to fix the CI validation issue

9b03fe3

Attempt to fix the CI-CD issue

1009ccf

agithomas marked this pull request as draft July 20, 2022 06:32

Readme updated

8945eb8

Minimum version supported updated

adab83f

ishleenk17 reviewed Jul 20, 2022

View reviewed changes

Optimized the pipeline. Updated version number.

3f76d68

muthu-mps reviewed Jul 21, 2022

View reviewed changes

agithomas added 5 commits July 21, 2022 13:25

Removed old dashboard style implementation. Fixes based on review fee…

56d6517

…dback

Fixes based on review feedback

f8d91a1

Fixed dashboard color differences. Fixed based on review feedback

291748b

Fixed typos

bb39c7a

Fixed minor issues and added sysmetrics field mappings fully

97f2ffc

agithomas marked this pull request as ready for review July 22, 2022 06:23

ishleenk17 reviewed Jul 22, 2022

View reviewed changes

packages/oracle/data_stream/tablespace/agent/stream/stream.yml.hbs Show resolved Hide resolved

packages/oracle/data_stream/tablespace/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved

packages/oracle/data_stream/sysmetric/manifest.yml Show resolved Hide resolved

ishleenk17 reviewed Jul 22, 2022

View reviewed changes

packages/oracle/kibana/dashboard/oracle-9e19fb00-08e1-11ed-9abf-15e60715cfab.json Outdated Show resolved Hide resolved

efd6 reviewed Jul 25, 2022

View reviewed changes

agithomas added 3 commits July 25, 2022 06:08

Fixed kibana version dependency. Fixed unwanted quotes

cd075b1

Added dashboard image files

aa9baf4

Fixed the documentation based on review feedback

2c6b42c

agithomas self-assigned this Jul 25, 2022

efd6 approved these changes Jul 26, 2022

View reviewed changes

lalit-satapathy reviewed Jul 26, 2022

View reviewed changes

packages/oracle/data_stream/performance/fields/fields.yml Outdated Show resolved Hide resolved

packages/oracle/data_stream/performance/fields/fields.yml Show resolved Hide resolved

packages/oracle/data_stream/sysmetric/manifest.yml Show resolved Hide resolved

ishleenk17 reviewed Jul 26, 2022

View reviewed changes

packages/oracle/data_stream/performance/fields/fields.yml Outdated Show resolved Hide resolved

packages/oracle/data_stream/performance/fields/fields.yml Outdated Show resolved Hide resolved

agithomas added 3 commits July 26, 2022 04:16

Fixed description, manifest information

e25c82f

Changes made to fields description to look consistent

458e4be

fixed typos and styling

81f8534

muthu-mps reviewed Jul 26, 2022

View reviewed changes

packages/oracle/manifest.yml Outdated Show resolved Hide resolved

agithomas added 2 commits July 26, 2022 05:51

Fixed policy template description

c160710

Fixed dashboard typo

20b0a10

ishleenk17 approved these changes Jul 26, 2022

View reviewed changes

agithomas merged commit bc5e89e into elastic:main Jul 26, 2022

andrewkroh mentioned this pull request Jul 27, 2022

[production] Promote many packages from snapshot elastic/package-storage#5029

Merged

agithomas deleted the feature-3580-3581-3582 branch February 12, 2025 05:02

andrewkroh added Integration:oracle Oracle dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Mar 13, 2025

Enancement to support Oracle sysmetrics tablespace and performance metrics #3759

Enancement to support Oracle sysmetrics tablespace and performance metrics #3759

Uh oh!

Conversation

agithomas commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

How to test this PR locally

Related issues

Screenshots

Uh oh!

elasticmachine commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

agithomas commented Jul 20, 2022

Uh oh!

elasticmachine commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muthu-mps commented Jul 21, 2022

Uh oh!

agithomas commented Jul 22, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishleenk17 commented Jul 22, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agithomas commented Jul 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agithomas commented Jul 26, 2022

Uh oh!

agithomas commented Jul 26, 2022

Uh oh!

Uh oh!

muthu-mps commented Jul 26, 2022

Uh oh!

agithomas commented Jul 26, 2022

Uh oh!

Uh oh!

agithomas commented Jul 19, 2022 •

edited

Loading

elasticmachine commented Jul 19, 2022 •

edited

Loading

elasticmachine commented Jul 20, 2022 •

edited

Loading