Skip to content

[AWS] Move natgateway lightweight module config into integration #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2022
Merged

[AWS] Move natgateway lightweight module config into integration #3873

merged 3 commits into from
Jul 28, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jul 27, 2022 •
edited
Loading

What does this PR do?

This PR is to move lightweight module configuration from Metricbeat into integrations for NATGateway.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Remove AWS resources used for testing

Related issues

@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jul 27, 2022
@zmoog zmoog self-assigned this Jul 27, 2022
@zmoog zmoog force-pushed the lw-mods-nat-gateway branch from 30e931f to 1f69bd9 Compare July 27, 2022 21:59
@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-27T23:12:32.444+0000

  • Duration: 35 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 346
Skipped 0
Total 346

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.465
Classes 91.667% (11/12) 👎 -5.465
Methods 82.243% (176/214) 👎 -7.018
Lines 92.894% (2157/2322) 👍 2.299
Conditionals 100.0% (0/0) 💚

@zmoog zmoog force-pushed the lw-mods-nat-gateway branch from a7f54ab to d763f9b Compare July 27, 2022 23:12
@zmoog zmoog marked this pull request as ready for review July 27, 2022 23:12
@zmoog zmoog requested a review from a team as a code owner July 27, 2022 23:12
girodav
girodav approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@girodav girodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zmoog zmoog merged commit 37674be into elastic:main Jul 28, 2022
@zmoog zmoog deleted the lw-mods-nat-gateway branch July 28, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girodav girodav girodav approved these changes

Assignees

@zmoog zmoog

Labels
enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lightweight modules from aws natgateway data stream
3 participants
@zmoog @elasticmachine @girodav