Skip to content

[Couchbase] Update manifest file for bucket data stream #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bhagyaraj-crest
Copy link
Contributor

  • Enhancement

What does this PR do?

Change host parameter from data stream specific manifest to integration specific manifest.

Why is this PR important?

For Couchbase, there can be multiple data streams for which we currently have a host inside the manifest (data stream specific), but it seems easier in terms of user experience to have the host field inside the main manifest (integration specific). Hence, the end-user won't have to enter the same host multiple times for multiple data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/couchbase directory.
  • Run the following command to run tests.

elastic-package test

ss1
ss2

@elasticmachine
Copy link

elasticmachine commented Jul 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-29T11:52:00.069+0000

  • Duration: 22 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani yug-rajani added enhancement New feature or request Integration:couchbase Couchbase Team:Service-Integrations Label for the Observability Service Integrations team labels Jul 29, 2022
@yug-rajani
Copy link
Contributor

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.868
Classes 100.0% (1/1) 💚 2.868
Methods 100.0% (7/7) 💚 10.749
Lines 100.0% (89/89) 💚 9.399
Conditionals 100.0% (0/0) 💚

@bhagyaraj-crest bhagyaraj-crest marked this pull request as ready for review August 1, 2022 04:59
@bhagyaraj-crest bhagyaraj-crest requested a review from a team as a code owner August 1, 2022 04:59
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:couchbase Couchbase Team:Service-Integrations Label for the Observability Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Couchbase package
5 participants