Skip to content

system/security: fix handling of events 4674, 4738 and 4742 #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 2, 2022

What does this PR do?

This fixes cases where NewUacValue and UserAccountControl are set to the
blank value ("-") in 4738 and 4742, and cases in 4674 where there is
more than one access mask value.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:system System labels Aug 2, 2022
@efd6 efd6 requested a review from a team August 2, 2022 04:35
@efd6 efd6 self-assigned this Aug 2, 2022
@efd6 efd6 marked this pull request as ready for review August 2, 2022 04:35
@efd6 efd6 requested a review from a team as a code owner August 2, 2022 04:35
@efd6 efd6 requested review from rdner and cmacknz August 2, 2022 04:35
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 changed the title system/security: fix handling of events 4674, 4738 and 3742 system/security: fix handling of events 4674, 4738 and 4742 Aug 2, 2022
This fixes cases where NewUacValue and UserAccountControl are set to the
blank value ("-") in 4738 and 4742, and cases in 4674 where there is
more than one access mask value.
@elasticmachine
Copy link

elasticmachine commented Aug 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-02T04:37:23.121+0000

  • Duration: 16 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 271
Skipped 0
Total 271

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 2.959
Classes 100.0% (4/4) 💚 2.959
Methods 60.759% (48/79) 👎 -29.116
Lines 98.793% (2702/2735) 👍 7.341
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:system System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in System integration
3 participants