Skip to content

[windows] add field to translate_sid processor in powershell operational #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Adds field to translate_sid processor in powershell operational datastream. Without the required field events can not be processed

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@leehinman leehinman added bug Something isn't working, use only for issues Team:Security-External Integrations labels Aug 11, 2022
@leehinman leehinman requested review from a team as code owners August 11, 2022 21:39
@leehinman leehinman requested review from rdner and faec August 11, 2022 21:39
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@leehinman leehinman force-pushed the 3988_windows_translate_sid branch from 29fa78b to 09a6f8c Compare August 11, 2022 21:40
@elasticmachine
Copy link

elasticmachine commented Aug 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-11T21:41:01.632+0000

  • Duration: 18 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -9.506
Classes 87.5% (7/8) 👎 -9.506
Methods 83.146% (74/89) 👎 -6.546
Lines 92.664% (5002/5398) 👍 1.17
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@leehinman leehinman merged commit cfe6fff into elastic:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[windows] missing field in translate_sid processor
3 participants