Skip to content

[system] fix adding additional processors in syslog data stream #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 5, 2022

What does this PR do?

Similar to #4395, this PR is to fix adding processors for syslog in system package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner October 5, 2022 20:45
@kaiyan-sheng kaiyan-sheng requested review from belimawr and rdner October 5, 2022 20:45
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 5, 2022
@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

🚀 Benchmarks report

Package system 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
syslog 14705.88 11627.91 -3077.97 (-20.93%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-05T20:46:25.145+0000

  • Duration: 15 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 246
Skipped 0
Total 246

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 2.508
Classes 100.0% (4/4) 💚 2.508
Methods 60.759% (48/79) 👎 -29.53
Lines 98.793% (2702/2735) 👍 7.158
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng merged commit 1cfd0ee into elastic:main Oct 6, 2022
@kaiyan-sheng kaiyan-sheng deleted the fix_processors_system branch October 6, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants