Skip to content

[oracle] Fixed performance data stream issues #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2022
Merged

[oracle] Fixed performance data stream issues #4421

merged 3 commits into from
Oct 11, 2022

Conversation

agithomas
Copy link
Contributor

Type of change

  • Bug

What does this PR do?

  • Fixed performance datastream issues.
  • updated readme with correct event json value (generated values)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • elastic-package lint
  • elastic-package format

How to test this PR locally

elastic-pacakge test system

Related issues

@agithomas agithomas mentioned this pull request Oct 7, 2022
Closed
@agithomas agithomas marked this pull request as ready for review October 7, 2022 14:08
@agithomas agithomas requested a review from a team as a code owner October 7, 2022 14:08
@andrewkroh andrewkroh changed the title Fixed performance datastream issues. [oracle] Fixed performance data stream issues Oct 7, 2022
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:oracle Oracle labels Oct 7, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 7, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-07T14:06:32.517+0000

  • Duration: 14 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.504
Classes 100.0% (1/1) 💚 2.504
Methods 82.759% (24/29) 👎 -7.557
Lines 89.13% (164/184) 👎 -2.51
Conditionals 100.0% (0/0) 💚

muthu-mps
muthu-mps reviewed Oct 10, 2022
View reviewed changes
packages/oracle/data_stream/performance/elasticsearch/ingest_pipeline/default.yml
@@ -50,7 +50,7 @@ processors:
ignore_failure: true
- rename:
field: oracle.performance.max_cur
target_field: racle.performance.cursors.max
target_field: oracle.performance.cursors.max
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change leaves the older field name as it is when we upgrade from 1.4.1 to 1.4.2 ?

@muthu-mps muthu-mps self-requested a review October 11, 2022 04:40
@agithomas agithomas merged commit a72ac4a into elastic:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:oracle Oracle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agithomas @elasticmachine @efd6 @muthu-mps @andrewkroh