Skip to content

panw: fix handling of event.outcome #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

panw: fix handling of event.outcome #4506

merged 1 commit into from
Oct 27, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 27, 2022 •
edited
Loading

What does this PR do?

This makes event.outcome dependent on event actions and results where appropriate. In some cases event.outcome is left empty as the original event does not have a success/failure state.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Oct 27, 2022
@efd6 efd6 self-assigned this Oct 27, 2022
@efd6
panw: fix handling of event.outcome
f4302db 
This makes event.outcome dependent on event actions and results where
appropriate. In some cases event.outcome is left empty as the original
event does not have a success/failure state.
@elasticmachine
Copy link

elasticmachine commented Oct 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-27T05:17:50.008+0000

  • Duration: 18 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 51
Skipped 0
Total 51

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

Package panw 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
panos 1008.06 483.56 -524.5 (-52.03%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚 2.707
Classes 100.0% (15/15) 💚 2.707
Methods 98.529% (67/68) 👍 8.541
Lines 94.529% (3214/3400) 👍 2.946
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review October 27, 2022 05:47
@efd6 efd6 requested a review from a team as a code owner October 27, 2022 05:47
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

ShourieG
ShourieG approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 6aefc64 into elastic:main Oct 27, 2022
@efd6 efd6 deleted the 4495-panw branch February 5, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panw: event.outcome is incorrectly always set to success
3 participants
@efd6 @elasticmachine @ShourieG