Skip to content

[AWS] Add "Data Granularity" parameter for metrics data streams #4515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 12, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Oct 27, 2022

What does this PR do?

Adds data_granularity parameter for metrics data streams and renames period parameter title to Collection Period.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gpop63 gpop63 force-pushed the add_aws_data-granularity_param branch from 9751113 to 84ab7e1 Compare October 27, 2022 23:37
@gpop63 gpop63 added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Oct 27, 2022
@elasticmachine
Copy link

elasticmachine commented Oct 27, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-12T09:26:36.885+0000

  • Duration: 47 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 179
Skipped 3
Total 182

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@gpop63 gpop63 force-pushed the add_aws_data-granularity_param branch from 84ab7e1 to 87126ca Compare October 27, 2022 23:50
@elasticmachine
Copy link

elasticmachine commented Oct 28, 2022

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Oct 28, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 93.333% (14/15) 👎 -4.2
Classes 93.333% (14/15) 👎 -4.2
Methods 85.214% (219/257) 👎 -5.384
Lines 96.022% (5914/6159) 👍 4.241
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review October 28, 2022 11:40
@gpop63 gpop63 requested a review from a team as a code owner October 28, 2022 11:40
@girodav
Copy link
Contributor

girodav commented Nov 14, 2022

/test

2 similar comments
@girodav
Copy link
Contributor

girodav commented Nov 15, 2022

/test

@girodav
Copy link
Contributor

girodav commented Nov 16, 2022

/test

@girodav
Copy link
Contributor

girodav commented Nov 17, 2022

CI failures probably related to elastic/fleet-server#2083

@girodav
Copy link
Contributor

girodav commented Jan 10, 2023

/test

@girodav girodav merged commit c81ea06 into elastic:main Jan 12, 2023
@elasticmachine
Copy link

Package aws - 1.29.0 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] Add a new "Data Granularity" advanced parameter for metrics-related integrations
5 participants