-
Notifications
You must be signed in to change notification settings - Fork 474
[Enhancement] Cisco FTD differentiating between inbound and outbound #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
/test |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
log |
823.72 | 228.36 | -595.36 (-72.28%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
Do we have a good idea about what Cisco mean when they include "to" in the connection description? Does it really mean "between"? |
honestly I think cisco themselves already have no actual idea what to means. My interpretation so far is: if no direction is specified, X to Y means, X is source and Y is destination. If a direction is specified, which luckily is only in 3 event codes, X to Y is dependant on the direction |
I can confirm this is indeed the correct assumption, at least based on their documentation of these specific event codes, a bit of a weird way to log this. From my perspective this change is 👍 |
What does this PR do?
I noticed some very odd Logs in FTD
The current extraction is:
network.direction: inbound (makes sense as it's extracted from log)
source.ip: 192.168.22.10
destination.ip: 216.160.83.56
In my opinion the source and destination IPs are flipped.
So this PR is to check if flipping them makes sense in the view of the community.
The main problem that I see, this change could potentially affect a lot of users who have already adapted to this way of life.
Cisco Documentation on this issue:
If inbound is specified, the original control connection was initiated from the outside. For example, for FTP, all data transfer channels are inbound if the original control channel is inbound. If outbound is specified, the original control connection was initiated from the inside.
Event Codes with this issue:
This change covers 302013 and 302015. I have sadly no sample logs for 302017
Checklist
changelog.yml
file.