Skip to content

radware,slack,sophos,squid,suricata,symantec,ti_*,tomcat: remove duplicate fields #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 15, 2022

What does this PR do?

Remove duplicate field definitions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:symantec_endpoint Symantec Endpoint Protection Integration:squid Squid Proxy Integration:sophos Sophos Integration:suricata Suricata Integration:radware Radware DefensePro Logs (Deprecated) Integration:ti_cybersixgill Cybersixgill Integration:slack Slack Logs (Community supported) labels Nov 15, 2022
@efd6 efd6 self-assigned this Nov 15, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T06:34:04.766+0000

  • Duration: 18 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 119
Skipped 3
Total 122

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022

🚀 Benchmarks report

Package sophos 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
utm 111111.11 13888.89 -97222.22 (-87.5%) 💔
xg 1059.32 574.38 -484.94 (-45.78%) 💔

Package squid 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 142857.14 27027.03 -115830.11 (-81.08%) 💔

Package suricata 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
eve 1007.05 514.14 -492.91 (-48.95%) 💔

Package symantec_endpoint 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1358.7 419.64 -939.06 (-69.11%) 💔

Package ti_threatq 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threat 2012.07 1280.41 -731.66 (-36.36%) 💔

Package tomcat 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 111111.11 28571.43 -82539.68 (-74.29%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (24/24) 💚
Classes 100.0% (24/24) 💚
Methods 95.392% (207/217) 👎 -4.608
Lines 93.35% (4127/4421) 👎 -0.968
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 15, 2022 05:07
@efd6 efd6 requested a review from a team as a code owner November 15, 2022 05:07
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 changed the title radware,slack,sophos,squid,suricata,symantec,ti_*: remove duplicate f… radware,slack,sophos,squid,suricata,symantec,ti_*,tomcat: remove duplicate fields Nov 15, 2022
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested. Rest LGTM 👍🏼

@efd6 efd6 merged commit c731f97 into elastic:main Nov 30, 2022
@elasticmachine
Copy link

Package radware - 0.10.1 containing this change is available at https://epr.elastic.co/search?package=radware

@elasticmachine
Copy link

Package slack - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=slack

@elasticmachine
Copy link

Package sophos - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=sophos

@elasticmachine
Copy link

Package squid - 0.11.1 containing this change is available at https://epr.elastic.co/search?package=squid

@elasticmachine
Copy link

Package suricata - 2.5.2 containing this change is available at https://epr.elastic.co/search?package=suricata

@elasticmachine
Copy link

Package symantec_endpoint - 2.1.1 containing this change is available at https://epr.elastic.co/search?package=symantec_endpoint

@elasticmachine
Copy link

Package ti_cybersixgill - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=ti_cybersixgill

@elasticmachine
Copy link

Package ti_threatq - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=ti_threatq

@elasticmachine
Copy link

Package tomcat - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=tomcat

@efd6 efd6 deleted the 4398-rst branch February 5, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:radware Radware DefensePro Logs (Deprecated) Integration:slack Slack Logs (Community supported) Integration:sophos Sophos Integration:squid Squid Proxy Integration:suricata Suricata Integration:symantec_endpoint Symantec Endpoint Protection Integration:ti_cybersixgill Cybersixgill
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants