Skip to content

[Cisco_Secure_Endpoint] Add drop processor for empty events #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Nov 25, 2022

What does this PR do?

If there are no events for the 24 hour interval, the Cisco API endpoint returns an empty data array, and the ingest pipeline processor returns processor failures because of this.

Its better to drop the empty event rather than storing ingest failures.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 25, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-25T12:26:48.279+0000

  • Duration: 15 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 4.444
Classes 100.0% (1/1) 💚 4.444
Methods 93.75% (15/16) 👍 5.315
Lines 89.216% (455/510) 👎 -3.368
Conditionals 100.0% (0/0) 💚

@P1llus P1llus merged commit ab8ef3d into elastic:main Nov 25, 2022
@elasticmachine
Copy link

Package cisco_secure_endpoint - 2.7.1 containing this change is available at https://epr.elastic.co/search?package=cisco_secure_endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants