Skip to content

[AWS] Change Kinesis integration documentation to Kinesis Data Stream #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Dec 8, 2022

What does this PR do?

This PR is to adjust Kinesis integration documentation to specify that this integration is to collect metrics for Kinesis Data Streams from CloudWatch.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screen Shot 2022-12-08 at 12 45 18 PM

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner December 8, 2022 19:49
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 8, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Dec 8, 2022
@elasticmachine
Copy link

elasticmachine commented Dec 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-08T19:49:31.549+0000

  • Duration: 39 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 177
Skipped 3
Total 180

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 93.333% (14/15) 👎 -6.667
Classes 93.333% (14/15) 👎 -6.667
Methods 85.156% (218/256) 👎 -1.51
Lines 96.018% (5908/6153) 👍 41.881
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the Kinesis family is getting bigger, and using the more precise name helps the user to know what they get with this integration.

LGTM!

@kaiyan-sheng kaiyan-sheng merged commit 0f4476a into elastic:main Dec 12, 2022
@kaiyan-sheng kaiyan-sheng deleted the kinesis_data_stream branch December 12, 2022 15:59
@kaiyan-sheng
Copy link
Contributor Author

@zmoog Yes exactly! We might have to consider at some point to rename the integration to kinesis data stream. But that would be a breaking change. As of right now, updating the documentation is step 1 to clarify what we are collecting with this specific integration. We will do the actual breaking change (if we decide that's necessary) as step 2 later.

@elasticmachine
Copy link

Package aws - 1.28.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants